Re: New package: brother-brscan5-1.2.12

[DerAndereJohannes <DerAndereJohannes@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 3804 bytes --]

New comment by DerAndereJohannes on void-packages repository

https://github.com/void-linux/void-packages/pull/44235#issuecomment-1694736834

Comment:
I had some time this evening. I went ahead to where the `brsaneconfig5 -q` command works correctly now (which completes it). It turns out that it uses avahi and that it also required the `brsaneconfig5` file to be present in the `/opt/...` folder tree... Technically avahi is not strictly necessary for the functioning of the package, so im not sure if it should be depends or as an optional addition.  I saw that there was also a new version available of the brother-brscan5 software (I am not sure if this would mean that the PR would have to change name). Below you can see my diff. It would be awesome to know if this looks any good. With this though, the network portion of this package should be sorted.

```
diff --git a/srcpkgs/brother-brscan5/template b/srcpkgs/brother-brscan5/template
index 171c0206bb..bc56e19e51 100644
--- a/srcpkgs/brother-brscan5/template
+++ b/srcpkgs/brother-brscan5/template
@@ -1,17 +1,17 @@
 # Template file for 'brother-brscan5'
 pkgname=brother-brscan5
-version=1.2.12
+version=1.2.13
 revision=1
 archs="i686 x86_64"
-depends="sane libusb-compat"
+depends="sane libusb-compat avahi"
 short_desc="SANE scanner driver for brscan5-compatible printers"
 maintainer="Alexandru Barbur <alex@ctrlc.name>"
 license="custom:EULA"
 homepage="https://support.brother.com/"
 repository="nonfree"
 nopie=yes
-conf_files="/etc/opt/brother/scanner/brscan5/brscan5.ini
- /etc/opt/brother/scanner/brscan5/brsanenetdevice.cfg
+conf_files="/opt/brother/scanner/brscan5/brscan5.ini
+ /opt/brother/scanner/brscan5/brsanenetdevice.cfg
  /opt/brother/scanner/brscan5/models/*.ini"
 
 _sane_library="libsane-brother5.so.1.0.7"
@@ -23,12 +23,12 @@ _pkg_libraries="libLxBsScanCoreApi.so.3.2.0
 if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
 	_rpmpkgid="0.x86_64"
 	distfiles="https://download.brother.com/welcome/dlf104036/brscan5-${version}-${_rpmpkgid}.rpm"
-	checksum="b40ef093be58d298e4429d8c5d4b7ecb48db58b64a5a01c203c9325c14997b47"
+	checksum="572d24efc23de14933cb15f8c8be20575af07d7aff32c3ddf0633bacffe9e098"
 	_rpmlibdir="usr/lib64"
 else
 	_rpmpkgid="0.i386"
 	distfiles="https://download.brother.com/welcome/dlf104035/brscan5-${version}-${_rpmpkgid}.rpm"
-	checksum="7e98f36494e4145c9192067519fe8a0b105eb54ec9ba8ce6474bfc2882f07e67"
+	checksum="4cdca918fb7f994fc1e081a3a709db8f5b4420406d26aa04a6effc941e468fc2"
 	_rpmlibdir="usr/lib"
 fi
 
@@ -49,9 +49,16 @@ do_install() {
 	popd
 
 	# note: configuration file locations are hard-coded in libsane-brother5.so
+	vinstall opt/brother/scanner/brscan5/brsaneconfig5 755 opt/brother/scanner/brscan5
+	vinstall opt/brother/scanner/brscan5/brscan5.ini 644 opt/brother/scanner/brscan5
+	vinstall opt/brother/scanner/brscan5/brsanenetdevice.cfg 644 opt/brother/scanner/brscan5
+	vinstall opt/brother/scanner/brscan5/brscan_cnetconfig 755 opt/brother/scanner/brscan5
+	vinstall opt/brother/scanner/brscan5/brscan_gnetconfig 755 opt/brother/scanner/brscan5
+
 	vmkdir etc/opt/brother/scanner/brscan5 755
-	vinstall opt/brother/scanner/brscan5/brscan5.ini 644 etc/opt/brother/scanner/brscan5
-	vinstall opt/brother/scanner/brscan5/brsanenetdevice.cfg 644 etc/opt/brother/scanner/brscan5
+	ln -sf /opt/brother/scanner/brscan5/brscan5.ini ${DESTDIR}/etc/opt/brother/scanner/brscan5/brscan5.ini
+	ln -sf /opt/brother/scanner/brscan5/brsanenetdevice.cfg ${DESTDIR}/etc/opt/brother/scanner/brscan5/brsanenetdevice.cfg
+	ln -sf /opt/brother/scanner/brscan5/models ${DESTDIR}/etc/opt/brother/scanner/brscan5/models
 
 	vmkdir opt/brother/scanner/brscan5 755
 	vcopy opt/brother/scanner/brscan5/models opt/brother/scanner/brscan5
```