From: mvf <mvf@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [WIP] New package: worker-4.12.1
Date: Wed, 30 Aug 2023 10:06:34 +0200 [thread overview]
Message-ID: <20230830080634.cVCNqmhHjuCShLkEt40rHGmSjinRY3lkiK6qmaKes-0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45807@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
New review comment by mvf on void-packages repository
https://github.com/void-linux/void-packages/pull/45807#discussion_r1309860992
Comment:
I don't think UDisks support makes it a dependency. When Worker first starts and generates the configuration, it shows this dialog:
![image](https://github.com/void-linux/void-packages/assets/304760/8d2a4c93-e33b-49d9-b33b-ffc6b10c0684)
On my machine with a system bus but no UDisks service, there are no error messages, console or otherwise. Merely the "Volume manager" dialog is not functional:
![image](https://github.com/void-linux/void-packages/assets/304760/f2ec00bc-8a98-4d58-aebb-8226a492a336)
IMHO, an `INSTALL.msg` that suggests users might want to install `udisks2` if they want to manage volumes from Worker would suffice. FWIW, the [Debian package](https://packages.debian.org/bookworm/worker) doesn't even suggest, let alone recommend or depend on `udisks`.
next prev parent reply other threads:[~2023-08-30 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 2:16 [PR PATCH] " mtboehlke
2023-08-29 2:16 ` [PR REVIEW] " mtboehlke
2023-08-29 2:16 ` mtboehlke
2023-08-30 8:06 ` mvf [this message]
2023-09-07 1:57 ` [PR PATCH] [Updated] " mtboehlke
2023-09-07 2:27 ` [PR REVIEW] " mtboehlke
2023-09-16 17:17 ` [PR PATCH] [Updated] " mtboehlke
2023-12-16 1:46 ` github-actions
2023-12-23 21:49 ` [PR PATCH] [Updated] " mtboehlke
2024-02-10 23:01 ` [PR PATCH] [Updated] New package: worker-5.0.0 mtboehlke
2024-05-11 1:45 ` New package: worker-5.0.1 github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830080634.cVCNqmhHjuCShLkEt40rHGmSjinRY3lkiK6qmaKes-0@z \
--to=mvf@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).