* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
@ 2023-08-30 18:53 ` classabbyamp
2023-08-30 19:39 ` Zapeth
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2023-08-30 18:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1699679097
Comment:
you could also [`noextract=/usr/lib/helix/runtime/grammars/*`](https://man.voidlinux.org/xbps.d#noextract=pattern)
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
2023-08-30 18:53 ` classabbyamp
@ 2023-08-30 19:39 ` Zapeth
2023-08-30 20:00 ` Bnyro
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Zapeth @ 2023-08-30 19:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
New comment by Zapeth on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1699732408
Comment:
Thanks, I wasn't aware of that option. That should also allow a custom selection of grammars that are relevant to the user, so I'll use that for the time being.
I still think a package separation would be more convenient, but if the consensus is that a user configuration is sufficient then feel free to close this issue.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
2023-08-30 18:53 ` classabbyamp
2023-08-30 19:39 ` Zapeth
@ 2023-08-30 20:00 ` Bnyro
2023-08-30 20:01 ` classabbyamp
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Bnyro @ 2023-08-30 20:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 458 bytes --]
New comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1699759201
Comment:
I'd assume that most users expect Helix to support all the treesitters out of the box as described in the official Helix docs.
If this will be done, we should also add a note about it that shows up when installing the package, or instead make helix depend on helix-grammars, and not vice-versa as described above.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (2 preceding siblings ...)
2023-08-30 20:00 ` Bnyro
@ 2023-08-30 20:01 ` classabbyamp
2023-08-31 16:48 ` mhmdanas
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2023-08-30 20:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1699679097
Comment:
you could also `noextract=/usr/lib/helix/runtime/grammars`
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (3 preceding siblings ...)
2023-08-30 20:01 ` classabbyamp
@ 2023-08-31 16:48 ` mhmdanas
2023-08-31 16:50 ` Bnyro
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mhmdanas @ 2023-08-31 16:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1701406236
Comment:
> I'd assume that most users expect Helix to support all the treesitters out of the box as described in the official Helix docs.
We could instead have `helix-minimal`, the core editor, and `helix`, which depends on both `helix-minimal` and `helix-grammars`.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (4 preceding siblings ...)
2023-08-31 16:48 ` mhmdanas
@ 2023-08-31 16:50 ` Bnyro
2023-08-31 17:06 ` tranzystorek-io
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: Bnyro @ 2023-08-31 16:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1701409746
Comment:
Cc maintainer @tranzystorek-io
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (5 preceding siblings ...)
2023-08-31 16:50 ` Bnyro
@ 2023-08-31 17:06 ` tranzystorek-io
2023-08-31 17:10 ` mhmdanas
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: tranzystorek-io @ 2023-08-31 17:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
New comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1701432271
Comment:
I'd rather avoid making this package more complex than it needs to be, unless it achieves sth more than just size optimization.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (6 preceding siblings ...)
2023-08-31 17:06 ` tranzystorek-io
@ 2023-08-31 17:10 ` mhmdanas
2023-08-31 17:23 ` classabbyamp
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mhmdanas @ 2023-08-31 17:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1701436485
Comment:
That's fine with me, but a `vmove` in a new subpackage isn't really that complicated, is it?
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (7 preceding siblings ...)
2023-08-31 17:10 ` mhmdanas
@ 2023-08-31 17:23 ` classabbyamp
2023-08-31 19:04 ` mhmdanas
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: classabbyamp @ 2023-08-31 17:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1701453336
Comment:
we don't need to subpackage everything
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (8 preceding siblings ...)
2023-08-31 17:23 ` classabbyamp
@ 2023-08-31 19:04 ` mhmdanas
2023-09-01 13:14 ` Zapeth
2023-09-01 13:14 ` [ISSUE] [CLOSED] " Zapeth
11 siblings, 0 replies; 13+ messages in thread
From: mhmdanas @ 2023-08-31 19:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 224 bytes --]
New comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1701604711
Comment:
Again, I don't object, I just disagree with the point that this is complicated.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (9 preceding siblings ...)
2023-08-31 19:04 ` mhmdanas
@ 2023-09-01 13:14 ` Zapeth
2023-09-01 13:14 ` [ISSUE] [CLOSED] " Zapeth
11 siblings, 0 replies; 13+ messages in thread
From: Zapeth @ 2023-09-01 13:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
New comment by Zapeth on void-packages repository
https://github.com/void-linux/void-packages/issues/45828#issuecomment-1702731779
Comment:
Then I'll close this, `noextract` is a good enough workaround me.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [ISSUE] [CLOSED] Suggestion - Split `helix-grammars` from `helix` package
2023-08-30 18:38 [ISSUE] Suggestion - Split `helix-grammars` from `helix` package Zapeth
` (10 preceding siblings ...)
2023-09-01 13:14 ` Zapeth
@ 2023-09-01 13:14 ` Zapeth
11 siblings, 0 replies; 13+ messages in thread
From: Zapeth @ 2023-09-01 13:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
Closed issue by Zapeth on void-packages repository
https://github.com/void-linux/void-packages/issues/45828
Description:
The `helix` package by default includes all its compiled treesitter grammars, which take up the majority of the package size (~110MB or 86% of the total size in the latest release, see also https://github.com/helix-editor/helix/issues/6187).
While it is useful to have LSP support for all these languages out of the box, I think it should be up to the user to decide if its worth the extra space, especially since its likely to increase as more languages get added.
So my suggestion would be to split the grammar *.so at `/usr/lib/helix/runtime/grammars` in an extra package `helix-grammars` that depends on `helix`.
^ permalink raw reply [flat|nested] 13+ messages in thread