From: jony255 <jony255@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: wf-recorder: update to 0.4.0.
Date: Tue, 05 Sep 2023 06:13:52 +0200 [thread overview]
Message-ID: <20230905041352.nKaidCSQ97uivh3DkQ3AAx7jU1AnVymVhccW-h_myKY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45884@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
New comment by jony255 on void-packages repository
https://github.com/void-linux/void-packages/pull/45884#issuecomment-1705919847
Comment:
I see
That was added in October of last year but there was an update to `sway` some time after that, which uses the same `git` commands that `wf-recorder` uses, and [it](https://github.com/void-linux/void-packages/pull/42236) passed
the `git` commands in question:
https://github.com/ammen99/wf-recorder/blob/master/meson.build#L25
https://github.com/swaywm/sway/blob/68d620a8fd70d70eb91c58dcfafc4af16c58379d/meson.build#L161
This PR should have also prevented this error: https://github.com/ammen99/wf-recorder/pull/226
The docs talking about `check: {true,false}`: https://mesonbuild.com/External-commands.html#external-commands
However, the relevant lines from the link are:
```If check: true is given, meson will error out if command returns with a non-zero exit code. Alternatively, you can set check: false and get the exit code with r.returncode().```
next prev parent reply other threads:[~2023-09-05 4:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 18:00 [PR PATCH] " jony255
2023-09-02 19:27 ` icp1994
2023-09-05 4:13 ` jony255
2023-09-05 4:13 ` jony255 [this message]
2023-09-05 4:16 ` jony255
2023-09-09 22:00 ` [PR PATCH] [Updated] " jony255
2023-09-21 21:22 ` mhmdanas
2023-09-23 13:14 ` [PR PATCH] [Merged]: " Duncaen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905041352.nKaidCSQ97uivh3DkQ3AAx7jU1AnVymVhccW-h_myKY@z \
--to=jony255@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).