Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: asusctl-4.6.2
@ 2023-05-27 22:27 hyperglue
  2023-05-29 19:50 ` [PR REVIEW] " abenson
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: hyperglue @ 2023-05-27 22:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There is a new pull request by hyperglue against master on the void-packages repository

https://github.com/hyperglue/void-packages asusctl
https://github.com/void-linux/void-packages/pull/44120

New package: asusctl-4.6.2
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/44120.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-asusctl-44120.patch --]
[-- Type: text/x-diff, Size: 1463 bytes --]

From d8663a26191ac2961adc18232c5c9ca1c6de820f Mon Sep 17 00:00:00 2001
From: hyperglue <prankster.superglue255@autumnmail.org>
Date: Sun, 28 May 2023 00:11:40 +0200
Subject: [PATCH] New package: asusctl-4.6.2

---
 srcpkgs/asusctl/files/asusd/run |  3 +++
 srcpkgs/asusctl/template        | 16 ++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 srcpkgs/asusctl/files/asusd/run
 create mode 100644 srcpkgs/asusctl/template

diff --git a/srcpkgs/asusctl/files/asusd/run b/srcpkgs/asusctl/files/asusd/run
new file mode 100644
index 000000000000..94e48b1045c4
--- /dev/null
+++ b/srcpkgs/asusctl/files/asusd/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+export IS_SERVICE=1
+exec asusd
diff --git a/srcpkgs/asusctl/template b/srcpkgs/asusctl/template
new file mode 100644
index 000000000000..1afb4a2ff45f
--- /dev/null
+++ b/srcpkgs/asusctl/template
@@ -0,0 +1,16 @@
+pkgname=asusctl
+version=4.6.2
+revision=1
+build_style="gnu-makefile"
+short_desc="A control daemon, CLI tools, and a collection of crates for interacting with ASUS ROG laptops"
+maintainer=""
+license="MPL-2.0"
+homepage="https://gitlab.com/asus-linux/asusctl"
+distfiles="https://gitlab.com/asus-linux/asusctl/-/archive/${version}/asusctl-${version}.tar.gz"
+checksum="9c478d29fea502afd5c9cc31eeac7cd5a1f0cfc2575b2e8e5b2201ad2b218f5d"
+makedepends="cargo pkgconf clang eudev-libudev-devel gdk-pixbuf-devel gtk+3-devel"
+depends="libayatana-appindicator"
+
+post_install() {
+	vsv asusd
+}

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] New package: asusctl-4.6.2
  2023-05-27 22:27 [PR PATCH] New package: asusctl-4.6.2 hyperglue
@ 2023-05-29 19:50 ` abenson
  2023-05-29 19:53 ` abenson
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: abenson @ 2023-05-29 19:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/44120#discussion_r1209531388

Comment:
This field needs to be set.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: New package: asusctl-4.6.2
  2023-05-27 22:27 [PR PATCH] New package: asusctl-4.6.2 hyperglue
  2023-05-29 19:50 ` [PR REVIEW] " abenson
@ 2023-05-29 19:53 ` abenson
  2023-08-28  1:45 ` github-actions
  2023-09-11  1:45 ` [PR PATCH] [Closed]: " github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: abenson @ 2023-05-29 19:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/44120#issuecomment-1567465251

Comment:
There will be a lot of issues given by xlint so please fix them before this gets run on CI.

Install the `xtools` package and run `xlint srcpkgs/asusctl/template`, then fix any of the identified issues.

I can already see it's going to complain about empty maintainer field, description being too long and starting with an article, and several of the variables are out of conventional order.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: New package: asusctl-4.6.2
  2023-05-27 22:27 [PR PATCH] New package: asusctl-4.6.2 hyperglue
  2023-05-29 19:50 ` [PR REVIEW] " abenson
  2023-05-29 19:53 ` abenson
@ 2023-08-28  1:45 ` github-actions
  2023-09-11  1:45 ` [PR PATCH] [Closed]: " github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2023-08-28  1:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44120#issuecomment-1694873468

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: New package: asusctl-4.6.2
  2023-05-27 22:27 [PR PATCH] New package: asusctl-4.6.2 hyperglue
                   ` (2 preceding siblings ...)
  2023-08-28  1:45 ` github-actions
@ 2023-09-11  1:45 ` github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2023-09-11  1:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

There's a closed pull request on the void-packages repository

New package: asusctl-4.6.2
https://github.com/void-linux/void-packages/pull/44120

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture: x86_64-glibc

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-09-11  1:45 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-27 22:27 [PR PATCH] New package: asusctl-4.6.2 hyperglue
2023-05-29 19:50 ` [PR REVIEW] " abenson
2023-05-29 19:53 ` abenson
2023-08-28  1:45 ` github-actions
2023-09-11  1:45 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).