From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] setup/git.sh: fix non-portable sed invocation
Date: Tue, 12 Sep 2023 06:18:20 +0200 [thread overview]
Message-ID: <20230912041820.hD7mhyj7pWbMUiTCu0XOMg8oxe96v3k3yKB4NmwukqM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46010@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/46010#discussion_r1322335132
Comment:
I think the only non-portable part is missing a semicolon `;` after `q`. All other parts are portable.
Can you try: ` sed -n '/^committer /{s/.*> \([0-9][0-9]*\) [-+][0-9].*/\1/p;q;}'`?
If it doesn't work, I would prefer this, instead:
```diff
diff --git a/common/environment/setup/git.sh b/common/environment/setup/git.sh
index bd72f2eae3..b9a5c692b8 100644
--- a/common/environment/setup/git.sh
+++ b/common/environment/setup/git.sh
@@ -18,7 +18,7 @@ elif [ -z "${SOURCE_DATE_EPOCH}" ]; then
export SOURCE_DATE_EPOCH="$(stat -c %Y ${XBPS_SRCPKGDIR}/${basepkg}/template)"
else
export SOURCE_DATE_EPOCH=$($XBPS_GIT_CMD -C ${XBPS_DISTDIR} cat-file commit HEAD |
- sed -n '/^committer /{s/.*> \([0-9][0-9]*\) [-+][0-9].*/\1/p;q}')
+ awk '/^commiter .* [-+][0-9]*$/{ print $(NF - 1); exit; }')
fi
fi
```
next prev parent reply other threads:[~2023-09-12 4:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 2:31 [PR PATCH] " q66
2023-09-11 11:38 ` q66
2023-09-12 3:41 ` [PR PATCH] [Updated] " q66
2023-09-12 3:41 ` q66
2023-09-12 4:18 ` sgn [this message]
2023-09-12 12:46 ` [PR PATCH] [Updated] " q66
2023-09-14 1:49 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912041820.hD7mhyj7pWbMUiTCu0XOMg8oxe96v3k3yKB4NmwukqM@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).