From: r-ricci <r-ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: clamav: update to 1.0.3.
Date: Thu, 14 Sep 2023 09:02:02 +0200 [thread overview]
Message-ID: <20230914070202.0B9lpdzIDF8MdwEktBgqQPp9nr8nQXHYdnxRnmr8o5A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46041@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
New comment by r-ricci on void-packages repository
https://github.com/void-linux/void-packages/pull/46041#issuecomment-1718875583
Comment:
> I had a look at the PR, and the patches seem quite unnecessary, especially `rust-optimize.patch`, which can be done by simply setting `CMAKE_BUILD_TYPE=Release`.
Usually void templates use the implicit `-DCMAKE_BUILD_TYPE=None` because this allows to use the flags set by xbps. But using Release is easier than adding a patch. I don't know which is better.
> I suppose it's better to update to the latest-and-greatest rather than an LTS version on Void Linux?
Latest stable is generally preferred.
I see your PR adds some useful improvements/cleanup, while lacking other things. Having to PRs creates confusion, I think one should be closed.
@jcgruenhage
next prev parent reply other threads:[~2023-09-14 7:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:39 [PR PATCH] clamav: update to 1.0.3, adopt nsudsgaard
2023-09-13 9:42 ` [PR PATCH] [Updated] " nsudsgaard
2023-09-13 20:54 ` r-ricci
2023-09-14 2:26 ` nsudsgaard
2023-09-14 3:47 ` classabbyamp
2023-09-14 3:53 ` [PR PATCH] [Updated] " nsudsgaard
2023-09-14 3:54 ` clamav: update to 1.0.3 nsudsgaard
2023-09-14 7:02 ` r-ricci [this message]
2023-09-14 7:04 ` r-ricci
2023-09-14 7:05 ` r-ricci
2023-09-14 10:55 ` nsudsgaard
2023-09-14 14:46 ` WIP: clamav: update to 1.2.0 nsudsgaard
2023-09-17 6:22 ` [PR PATCH] [Updated] " nsudsgaard
2023-09-17 6:25 ` [PR PATCH] [Merged]: " Johnnynator
2023-09-18 9:20 ` jcgruenhage
2023-09-18 12:39 ` nsudsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230914070202.0B9lpdzIDF8MdwEktBgqQPp9nr8nQXHYdnxRnmr8o5A@z \
--to=r-ricci@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).