From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: helvum: update to 0.4.1.
Date: Sun, 17 Sep 2023 08:15:39 +0200 [thread overview]
Message-ID: <20230917061539.wTiq5a3QhyAC7DoQ_byy7-r19BLqeFVhSwbwNraO6A0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46082@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/46082#issuecomment-1722403396
Comment:
A bit tangential, this template uses the `cargo` build style instead of the `meson` one and recommends checking all `meson.build` files during each update. I think this is probably not the ideal approach so I had these changes when I updated it locally a few months ago.
```patch
diff --git a/srcpkgs/helvum/template b/srcpkgs/helvum/template
index 1f3c89a66..071033ee1 100644
--- a/srcpkgs/helvum/template
+++ b/srcpkgs/helvum/template
@@ -2,10 +2,12 @@
pkgname=helvum
version=0.4.0
revision=1
-build_style=cargo
-hostmakedepends="pkg-config clang libclang"
-makedepends="gtk4-devel pipewire-devel glib-devel"
+build_style=meson
+build_helper="rust"
+hostmakedepends="pkg-config clang libclang cargo desktop-file-utils gtk4-update-icon-cache"
+makedepends="gtk4-devel pipewire-devel glib-devel rust-std"
depends="pipewire"
+checkdepends="desktop-file-utils appstream-glib"
short_desc="GTK patchbay for pipewire"
maintainer="0x5c <dev@0x5c.io>"
license="GPL-3.0-only"
@@ -13,17 +15,9 @@ homepage="https://gitlab.freedesktop.org/pipewire/helvum"
distfiles="https://gitlab.freedesktop.org/pipewire/helvum/-/archive/${version}/helvum-${version}.tar.gz"
checksum=e93afa788d3e50bae489db888ecf0d79e5735b8f4f8b29fe4174540b0872b622
-post_install() {
- # Normally, meson would do this, but it's simpler to use the cargo build style and do this manually
- # This also avoids the need for makedeps/build steps that are made unnecessary by xbps' hooks
- # On update, all meson.build files should be checked for changes
- _app_id='org.pipewire.Helvum'
- vinstall data/icons/$_app_id.svg 644 usr/share/icons/hicolor/scalable/apps/
- vinstall data/icons/$_app_id-symbolic.svg 644 usr/share/icons/hicolor/symbolic/apps/
-
- vsed -i data/$_app_id.desktop.in -e "s/@icon@/$_app_id/"
- vinstall data/$_app_id.desktop.in 644 usr/share/applications/ $_app_id.desktop
-
- vsed -i data/$_app_id.metainfo.xml.in -e "s/@app-id@/$_app_id/"
- vinstall data/$_app_id.metainfo.xml.in 644 usr/share/metainfo/ $_app_id.metainfo.xml
+post_patch() {
+ if [ "$CROSS_BUILD" ]; then
+ vsed -i src/meson.build \
+ -e "s%rust_target /%'${RUST_TARGET}' / rust_target /%"
+ fi
}
```
next prev parent reply other threads:[~2023-09-17 6:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 10:14 [PR PATCH] " 0x5c
2023-09-16 11:54 ` tranzystorek-io
2023-09-16 12:32 ` 0x5c
2023-09-16 15:18 ` [PR PATCH] [Updated] " 0x5c
2023-09-16 15:33 ` 0x5c
2023-09-17 2:54 ` 0x5c
2023-09-17 6:15 ` icp1994 [this message]
2023-09-17 8:13 ` 0x5c
2023-09-17 8:13 ` 0x5c
2023-09-17 8:18 ` 0x5c
2023-09-17 10:43 ` icp1994
2023-09-18 7:55 ` 0x5c
2023-09-18 7:55 ` 0x5c
2023-09-20 12:14 ` [PR PATCH] [Updated] " 0x5c
2023-09-20 12:27 ` 0x5c
2023-09-20 12:29 ` 0x5c
2023-09-26 18:10 ` [PR PATCH] [Updated] " 0x5c
2023-09-26 18:20 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230917061539.wTiq5a3QhyAC7DoQ_byy7-r19BLqeFVhSwbwNraO6A0@z \
--to=icp1994@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).