From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC, WIP] common/build-helper/meson.sh: new build helper, used by meson build style
Date: Thu, 21 Sep 2023 00:16:43 +0200 [thread overview]
Message-ID: <20230920221643.GNW_IssKWJLDwqHRlpqPRCYC-5CSAAsqakS44GDqB6o@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46117@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 735 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/46117#issuecomment-1728497585
Comment:
Looks nice. I will try it on `python3-contourpy`.
Random thoughts:
1. Would it make sense to set `-Csetup-args=--cross-file=${XBPS_WRAPPERDIR}/meson/xbps_meson.cross` in the `python3-pep517` style (only if using meson helper), or is that "too much magic"?
2. Would it make sense to place the configuration for numpy and
pythran in `xbps_meson.cross` itself? I assume unused properties are harmless.
3. The helper seems to be called several times at different stages, so the crossfile would be written several times, maybe with different content? Could this be an issue in some case?
next prev parent reply other threads:[~2023-09-20 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 19:53 [PR PATCH] " ahesford
2023-09-18 20:02 ` tornaria
2023-09-20 3:25 ` tornaria
2023-09-20 14:46 ` [PR PATCH] [Updated] " ahesford
2023-09-20 14:48 ` ahesford
2023-09-20 14:50 ` ahesford
2023-09-20 14:54 ` ahesford
2023-09-20 15:13 ` [PR PATCH] [Updated] " ahesford
2023-09-20 15:16 ` ahesford
2023-09-20 22:16 ` tornaria [this message]
2023-09-21 0:36 ` [RFC] " ahesford
2023-09-21 0:50 ` ahesford
2023-09-21 0:51 ` ahesford
2023-09-21 19:28 ` [PR PATCH] [Updated] " ahesford
2023-09-22 14:17 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920221643.GNW_IssKWJLDwqHRlpqPRCYC-5CSAAsqakS44GDqB6o@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).