From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] common/build-helper/meson.sh: new build helper, used by meson build style
Date: Thu, 21 Sep 2023 02:50:52 +0200 [thread overview]
Message-ID: <20230921005052.6pXsPyF1ODjqvmLsW_LFdUpKFM6NAnqAqJmhVEA2k9A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46117@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/46117#issuecomment-1728605077
Comment:
> 1. Would it make sense to set `-Csetup-args=--cross-file=${XBPS_WRAPPERDIR}/meson/xbps_meson.cross` in the `python3-pep517` style (only if using meson helper), or is that "too much magic"?
I think adding this argument to the PEP517 style is reasonable. It shouldn't be "too much magic" because it confines its manipulations to the actual build functions where this kind of thing is expected.
> 2. Would it make sense to place the configuration for numpy and
> pythran in `xbps_meson.cross` itself? I assume unused properties are harmless.
This would probably better in the numpy build helper, which can check if the meson helper is also enabled and write a second cross file. We can then add another check in the PEP517 helper to automatically add the second file to the build arguments.
> 3. The helper seems to be called several times at different stages, so the crossfile would be written several times, maybe with different content? Could this be an issue in some case?
it bought about this and decided to follow the precedent of the qmake helper, but we could also add a check to avoid writing the file if it already exists. I'm not sure it matters.
While I'm inclined to adopt the numpy and pep517 improvements, let's consider those in a separate PR after this more general change is merged.
next prev parent reply other threads:[~2023-09-21 0:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 19:53 [PR PATCH] [RFC, WIP] " ahesford
2023-09-18 20:02 ` tornaria
2023-09-20 3:25 ` tornaria
2023-09-20 14:46 ` [PR PATCH] [Updated] " ahesford
2023-09-20 14:48 ` ahesford
2023-09-20 14:50 ` ahesford
2023-09-20 14:54 ` ahesford
2023-09-20 15:13 ` [PR PATCH] [Updated] " ahesford
2023-09-20 15:16 ` ahesford
2023-09-20 22:16 ` tornaria
2023-09-21 0:36 ` [RFC] " ahesford
2023-09-21 0:50 ` ahesford [this message]
2023-09-21 0:51 ` ahesford
2023-09-21 19:28 ` [PR PATCH] [Updated] " ahesford
2023-09-22 14:17 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921005052.6pXsPyF1ODjqvmLsW_LFdUpKFM6NAnqAqJmhVEA2k9A@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).