Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] qutebrowser: work around drag-and-drop crash on wayland-egl.
@ 2023-09-20 12:22 mhmdanas
  2023-09-22  2:22 ` [PR PATCH] [Merged]: " ahesford
  0 siblings, 1 reply; 2+ messages in thread
From: mhmdanas @ 2023-09-20 12:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

There is a new pull request by mhmdanas against master on the void-packages repository

https://github.com/mhmdanas/void-packages qutebrowser-fix-wayland-egl-crash
https://github.com/void-linux/void-packages/pull/46153

qutebrowser: work around drag-and-drop crash on wayland-egl.
Proper fix coming in Qt 6.5.3.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

@daniel-eys

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46153.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qutebrowser-fix-wayland-egl-crash-46153.patch --]
[-- Type: text/x-diff, Size: 2259 bytes --]

From ae702d5ff407f2e9d46e24457010042bd740d524 Mon Sep 17 00:00:00 2001
From: triallax <triallax@tutanota.com>
Date: Wed, 20 Sep 2023 13:20:39 +0100
Subject: [PATCH] qutebrowser: work around drag-and-drop crash on wayland-egl.

Proper fix coming in Qt 6.5.3.
---
 .../fix-wayland-egl-drag-and-drop.patch       | 23 +++++++++++++++++++
 srcpkgs/qutebrowser/template                  |  2 +-
 2 files changed, 24 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/qutebrowser/patches/fix-wayland-egl-drag-and-drop.patch

diff --git a/srcpkgs/qutebrowser/patches/fix-wayland-egl-drag-and-drop.patch b/srcpkgs/qutebrowser/patches/fix-wayland-egl-drag-and-drop.patch
new file mode 100644
index 0000000000000..8a01581a705ac
--- /dev/null
+++ b/srcpkgs/qutebrowser/patches/fix-wayland-egl-drag-and-drop.patch
@@ -0,0 +1,23 @@
+From b317038a01094136d06d4cb769b7755450b94f61 Mon Sep 17 00:00:00 2001
+From: Florian Bruhin <me@the-compiler.org>
+Date: Mon, 18 Sep 2023 18:03:21 +0200
+Subject: [PATCH] eventfilter: Also enable workaround on wayland-egl
+
+Will be fixed nicely on main, this is a more minimal fix
+---
+ qutebrowser/keyinput/eventfilter.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/qutebrowser/keyinput/eventfilter.py b/qutebrowser/keyinput/eventfilter.py
+index 306d4405b6d..ce9959bd4e3 100644
+--- a/qutebrowser/keyinput/eventfilter.py
++++ b/qutebrowser/keyinput/eventfilter.py
+@@ -86,7 +86,7 @@ def eventFilter(self, obj: Optional[QObject], event: Optional[QEvent]) -> bool:
+ 
+         if (
+             ev_type == QEvent.Type.DragEnter and
+-            objects.qapp.platformName() == "wayland" and
++            objects.qapp.platformName() in ["wayland", "wayland-egl"] and
+             qVersion() == "6.5.2"
+         ):
+             # WORKAROUND for https://bugreports.qt.io/browse/QTBUG-115757
diff --git a/srcpkgs/qutebrowser/template b/srcpkgs/qutebrowser/template
index b06a4ae4cda04..f2e8904d7afd1 100644
--- a/srcpkgs/qutebrowser/template
+++ b/srcpkgs/qutebrowser/template
@@ -1,7 +1,7 @@
 # Template file for 'qutebrowser'
 pkgname=qutebrowser
 version=3.0.0
-revision=1
+revision=2
 build_style=python3-module
 hostmakedepends="python3-setuptools asciidoc"
 depends="python3-Jinja2 python3-yaml"

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: qutebrowser: work around drag-and-drop crash on wayland-egl.
  2023-09-20 12:22 [PR PATCH] qutebrowser: work around drag-and-drop crash on wayland-egl mhmdanas
@ 2023-09-22  2:22 ` ahesford
  0 siblings, 0 replies; 2+ messages in thread
From: ahesford @ 2023-09-22  2:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

There's a merged pull request on the void-packages repository

qutebrowser: work around drag-and-drop crash on wayland-egl.
https://github.com/void-linux/void-packages/pull/46153

Description:
Proper fix coming in Qt 6.5.3.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

@daniel-eys

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-09-22  2:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-20 12:22 [PR PATCH] qutebrowser: work around drag-and-drop crash on wayland-egl mhmdanas
2023-09-22  2:22 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).