From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gdm: fix language selection by ensuring LANG equals GDM_LANG
Date: Fri, 22 Sep 2023 22:42:10 +0200 [thread overview]
Message-ID: <20230922204210.TaSEWk0AC7j-7lPps33FX0r8ZcSInFLgS_ljLKzadlg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44545@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44545#discussion_r1334799755
Comment:
```suggestion
## This must run after locale.sh ##
# GDM expects that the shell will respect what it sets in LANG, but login
# shells will overwrite any locale information based on the contents of
# /etc/locale.conf. Because GDM also sets GDM_LANG to its desired language, we
# can just force the value here after locale.conf has been parsed.
```
next prev parent reply other threads:[~2023-09-22 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 21:21 [PR PATCH] gdm: fix language selection by ensuring LANG=GDM_LANG oreo639
2023-06-20 21:33 ` [PR PATCH] [Updated] " oreo639
2023-09-19 1:45 ` gdm: fix language selection by ensuring LANG equals GDM_LANG github-actions
2023-09-19 2:00 ` oreo639
2023-09-22 20:42 ` ahesford [this message]
2023-09-22 20:42 ` [PR REVIEW] " ahesford
2023-12-22 1:46 ` github-actions
2023-12-22 2:17 ` [PR PATCH] [Updated] " oreo639
2023-12-22 2:26 ` oreo639
2024-03-23 1:44 ` github-actions
2024-04-07 1:46 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922204210.TaSEWk0AC7j-7lPps33FX0r8ZcSInFLgS_ljLKzadlg@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).