From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Add meson awareness to `numpy` helper and `python3-pep517` style
Date: Sat, 23 Sep 2023 14:24:14 +0200 [thread overview]
Message-ID: <20230923122414.1yUZrJbqrwIPEpiDQ2KV6JTE6QK8aQ93JCy3TjSaHhs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46186@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/46186#issuecomment-1732297940
Comment:
You may want to cherry-pick 0a2141b19ad from #46109, to further cleanup the scipy template (no need for the pybind11 thing).
I wonder about this:
```
if [ "$CROSS_BUILD" ]; then
# Meson can't tolerate $CC with arguments as set by the build helper
CC="${XBPS_CROSS_TRIPLET}-gcc"
# CXX needs to know where to find Python headers
CXXFLAGS+=" -I${XBPS_CROSS_BASE}/${py3_inc}"
fi
```
Is this necessary? I didn't add this to `python3-contourpy` and I had no trouble... This block is there both in scipy and scikit-image.
next prev parent reply other threads:[~2023-09-23 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:21 [PR PATCH] " ahesford
2023-09-22 14:32 ` [PR PATCH] [Updated] " ahesford
2023-09-23 11:50 ` tornaria
2023-09-23 12:08 ` ahesford
2023-09-23 12:24 ` tornaria [this message]
2023-09-23 12:26 ` tornaria
2023-09-23 14:14 ` ahesford
2023-09-23 16:52 ` ahesford
2023-09-23 16:52 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230923122414.1yUZrJbqrwIPEpiDQ2KV6JTE6QK8aQ93JCy3TjSaHhs@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).