From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New packages: ayugram-desktop-4.9.4, ayugram-desktop-sysfont-4.9.4
Date: Mon, 25 Sep 2023 17:39:02 +0200 [thread overview]
Message-ID: <20230925153902.ru5s5uaFSFVG7pTvSkyakQVoTkR1X1O-qanxhCy6kzI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46248@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/46248#issuecomment-1733976837
Comment:
Packages that just clone a git repository in `do_fetch` are not acceptable. A GitHub archive should be fetched properly.
The `ayugram-desktop` and `ayugram-desktop-sysfont` templates seem identical, at least as far as I can tell paging back and forth. What is the difference between them?
Use of `broken=` to disable unsupported archs is not appropriate. The `archs` variable should be used for proper architecture restrictions.
next prev parent reply other threads:[~2023-09-25 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 14:37 [PR PATCH] " incycledream
2023-09-25 15:39 ` ahesford [this message]
2023-09-25 15:47 ` incycledream
2023-09-25 15:48 ` ahesford
2023-09-25 16:02 ` Johnnynator
2023-09-25 16:02 ` [PR PATCH] [Closed]: " Johnnynator
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925153902.ru5s5uaFSFVG7pTvSkyakQVoTkR1X1O-qanxhCy6kzI@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).