Github messages for voidlinux
 help / color / mirror / Atom feed
From: sogaiu <sogaiu@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] ibus-hangul: update to 1.5.5
Date: Wed, 27 Sep 2023 11:27:25 +0200	[thread overview]
Message-ID: <20230927092725.O15hDsQHMcYRfAOUNKV40n7npDwn98bYu4E8uP3Ssd4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46271@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

There is an updated pull request by sogaiu against master on the void-packages repository

https://github.com/sogaiu/void-packages update-ibus-hangul
https://github.com/void-linux/void-packages/pull/46271

ibus-hangul: update to 1.5.5
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

#### Notes

Apparently, [recent versions of Python no longer have `gettext.bind_textdomain_codeset`](https://docs.python.org/3.10/library/gettext.html#gettext.bind_textdomain_codeset).

For recent Pythons, ibus-hangul 1.5.3's `ibus-setup-hangul` can crash with:

```
$ ibus-setup-hangul 
Traceback (most recent call last):
  File "/usr/share/ibus-hangul/setup/main.py", line 298, in <module>
    gettext.bind_textdomain_codeset(config.gettext_package, "UTF-8")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'gettext' has no attribute 'bind_textdomain_codeset'
```

A [PR for ibus-hangul to address this](https://github.com/libhangul/ibus-hangul/issues/93) was merged some time back and [the 1.5.4 release included the relevant code](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.4).

There was [another release (1.5.5)](https://github.com/libhangul/ibus-hangul/releases/tag/1.5.5) since then and this PR is an update to that one.


A patch file from https://github.com/void-linux/void-packages/pull/46271.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-ibus-hangul-46271.patch --]
[-- Type: text/x-diff, Size: 1853 bytes --]

From 615948deae274c7e409ad95211a96ab582eb9f0b Mon Sep 17 00:00:00 2001
From: sogaiu <983021772@users.noreply.github.com>
Date: Wed, 27 Sep 2023 01:18:29 +0900
Subject: [PATCH] ibus-hangul: update to 1.5.5

---
 srcpkgs/ibus-hangul/template | 10 +++++-----
 srcpkgs/ibus-hangul/update   |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/ibus-hangul/template b/srcpkgs/ibus-hangul/template
index 66f1dd5527882..bf8cec311f7d3 100644
--- a/srcpkgs/ibus-hangul/template
+++ b/srcpkgs/ibus-hangul/template
@@ -1,18 +1,18 @@
 # Template file for 'ibus-hangul'
 pkgname=ibus-hangul
-version=1.5.3
+version=1.5.5
 revision=1
 build_style=gnu-configure
 configure_args="--libexec=/usr/lib/ibus --with-python=/usr/bin/python3"
 hostmakedepends="gettext libtool pkg-config swig"
-makedepends="ibus-devel libhangul-devel"
+makedepends="gtk+3-devel ibus-devel libhangul-devel"
 depends="ibus librsvg python3-gobject"
 short_desc="Korean input engine for IBus"
 maintainer="Michael Aldridge <maldridge@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="https://github.com/choehwanjin/ibus-hangul"
-distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.gz"
-checksum=5e661cd77a327b1eafacd537f7d839a61a374e951bd382044e799371855a0090
+homepage="https://github.com/libhangul/ibus-hangul"
+distfiles="${homepage}/releases/download/${version}/${pkgname}-${version}.tar.xz"
+checksum=a5aac88286cd18960229860e3e1a778978a7aeaa484ad9acfa48284b87fdc3bb
 
 if [ "$CROSS_BUILD" ]; then
 	hostmakedepends+=" python3"
diff --git a/srcpkgs/ibus-hangul/update b/srcpkgs/ibus-hangul/update
index 608f1c0bc1995..4ba8a7ba970f8 100644
--- a/srcpkgs/ibus-hangul/update
+++ b/srcpkgs/ibus-hangul/update
@@ -1 +1 @@
-site="https://github.com/choehwanjin/ibus-hangul/releases"
+site="https://github.com/libhangul/ibus-hangul/releases"

  reply	other threads:[~2023-09-27  9:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26 16:35 [PR PATCH] " sogaiu
2023-09-27  9:27 ` sogaiu [this message]
2023-09-27 10:08 ` sogaiu
2023-09-27 10:09 ` sogaiu
2023-09-27 14:00 ` [PR REVIEW] " sgn
2023-09-27 14:00 ` [PR PATCH] [Updated] " sgn
2023-09-28  1:12 ` sogaiu
2023-09-28  1:22 ` sogaiu
2023-09-28  1:25 ` sogaiu
2023-09-28  1:26 ` sogaiu
2023-09-28  1:27 ` sogaiu
2023-09-28  1:28 ` sogaiu
2023-09-28  1:39 ` sogaiu
2023-09-28  4:31 ` sogaiu
2023-09-28  7:47 ` [PR PATCH] [Updated] " sogaiu
2023-09-28  7:49 ` sogaiu
2023-09-28  7:50 ` sogaiu
2023-09-28  8:36 ` sogaiu
2023-09-29  2:01 ` sogaiu
2023-09-29  2:57 ` sogaiu
2023-09-29  2:59 ` sogaiu
2023-09-29  3:02 ` sogaiu
2023-09-29 15:54 ` sogaiu
2023-09-30  9:31 ` sgn
2023-09-30  9:33 ` sogaiu
2023-09-30  9:33 ` [PR PATCH] [Closed]: " sogaiu
2023-09-30  9:34 ` sogaiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927092725.O15hDsQHMcYRfAOUNKV40n7npDwn98bYu4E8uP3Ssd4@z \
    --to=sogaiu@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).