Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] nerd-fonts: split symbols font
Date: Sat, 30 Sep 2023 16:54:11 +0200	[thread overview]
Message-ID: <20230930145411.jlTCREyNKuM68xmwei208NJIgJqjtWJjPTrpycX1PLY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46319@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/46319#discussion_r1341971108

Comment:
I would remove `Symbols` in `do_install` and 
```suggestion
	font_dirs="/usr/share/fonts/NerdFonts/symbols"
	depends="font-util"
	pkg_install() {
		vinstall patched-fonts/NerdFontsSymbolsOnly/SymbolsNerdFont-Regular.ttf
		vinstall patched-fonts/NerdFontsSymbolsOnly/SymbolsNerdFontMono-Regular.ttf
```

  reply	other threads:[~2023-09-30 14:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28 21:42 [PR PATCH] " classabbyamp
2023-09-30 14:54 ` sgn [this message]
2023-09-30 17:33 ` [PR PATCH] [Updated] " classabbyamp
2023-09-30 19:58 ` [PR REVIEW] " chrysos349
2023-09-30 20:08 ` classabbyamp
2023-10-02  1:44 ` cinerea0
2023-10-02  1:45 ` classabbyamp
2023-10-02 13:48 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230930145411.jlTCREyNKuM68xmwei208NJIgJqjtWJjPTrpycX1PLY@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).