Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] xdg-desktop-portal: include a default portals.conf
Date: Thu, 05 Oct 2023 18:29:26 +0200	[thread overview]
Message-ID: <20231005162926.kMtcBbfHvm5SStk-4OooHDPJgmPPcnV_MBf8EJCfbNo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46449@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages portal-conf
https://github.com/void-linux/void-packages/pull/46449

xdg-desktop-portal: include a default portals.conf
Without this, `xdg-desktop-portal` cannot do anything as of 1.18.0. DEs and WMs should probably ship their own if they want to use a specific frontend, but this should be good enough for now.

This conf file is put in the lowest precedence location, and generic `portals.conf` is overriden if `XDG_CURRENT_DESKTOP-portals.conf` is found, so this should be fairly safe.

Additionally, this `portals.conf` does not require any specific frontend, just the special value `*`, which means the first one found in lexicographical order.

See [portals.conf(5)](https://github.com/flatpak/xdg-desktop-portal/blob/main/doc/portals-conf.rst) for more details. This manpage is also installed now by adding `python3-docutils` to `hostmakedepends`.

fixes #46317

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**



A patch file from https://github.com/void-linux/void-packages/pull/46449.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-portal-conf-46449.patch --]
[-- Type: text/x-diff, Size: 2482 bytes --]

From 2ece48f914478134a5ba324b4b176926fa65a88b Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 5 Oct 2023 12:17:40 -0400
Subject: [PATCH] xdg-desktop-portal: include a default portals.conf

Without this, `xdg-desktop-portal` cannot do anything as of 1.18.0. DEs
and WMs should probably ship their own if they want to use a specific
frontend, but this should be good enough for now.

This conf file is put in the lowest precedence location, and generic
`portals.conf` is overriden if `XDG_CURRENT_DESKTOP-portals.conf` is found,
so this should be fairly safe.

Additionally, this `portals.conf` does not require any specific frontend,
just the special value `*`, which means the first one found in
lexicographical order.

See [portals.conf(5)](https://github.com/flatpak/xdg-desktop-portal/blob/main/doc/portals-conf.rst)
for more details. This manpage is also installed now by adding
`python3-docutils` to `hostmakedepends`.

fixes #46317
---
 srcpkgs/xdg-desktop-portal/files/portals.conf | 2 ++
 srcpkgs/xdg-desktop-portal/template           | 8 ++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/xdg-desktop-portal/files/portals.conf

diff --git a/srcpkgs/xdg-desktop-portal/files/portals.conf b/srcpkgs/xdg-desktop-portal/files/portals.conf
new file mode 100644
index 0000000000000..028e24d2bbee7
--- /dev/null
+++ b/srcpkgs/xdg-desktop-portal/files/portals.conf
@@ -0,0 +1,2 @@
+[preferred]
+default=*
diff --git a/srcpkgs/xdg-desktop-portal/template b/srcpkgs/xdg-desktop-portal/template
index 54b760529a5d1..a2e302d86081a 100644
--- a/srcpkgs/xdg-desktop-portal/template
+++ b/srcpkgs/xdg-desktop-portal/template
@@ -1,11 +1,11 @@
 # Template file for 'xdg-desktop-portal'
 pkgname=xdg-desktop-portal
 version=1.18.0
-revision=1
+revision=2
 build_style=meson
 configure_args="-Dgeoclue=enabled -Dlibportal=enabled
  -Dsystemd=disabled"
-hostmakedepends="pkg-config gettext glib-devel bubblewrap flatpak"
+hostmakedepends="pkg-config gettext glib-devel bubblewrap flatpak python3-docutils"
 makedepends="flatpak-devel fuse3-devel pipewire-devel geoclue2-devel
  libportal-devel polkit-devel"
 checkdepends="dbus python3-dbusmock"
@@ -20,3 +20,7 @@ checksum=4c8a017fb3c894ec46c03d08e6b6c3d31259707bdb3c7ee8aedb3a0cc0b4d707
 if [ "$XBPS_BUILD_ENVIRONMENT" = "void-packages-ci" ]; then
 	export TEST_IN_CI="true"
 fi
+
+post_install() {
+	vinstall "${FILESDIR}"/portals.conf 644 usr/share/xdg-desktop-portal
+}

  reply	other threads:[~2023-10-05 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 16:28 [PR PATCH] " classabbyamp
2023-10-05 16:29 ` classabbyamp [this message]
2023-10-05 16:52 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231005162926.kMtcBbfHvm5SStk-4OooHDPJgmPPcnV_MBf8EJCfbNo@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).