Github messages for voidlinux
 help / color / mirror / Atom feed
From: r-ricci <r-ricci@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] py2->3 fixes
Date: Sun, 08 Oct 2023 12:28:26 +0200	[thread overview]
Message-ID: <20231008102826.RXEdVnp6LnkAqC-y4aHjY1SXwQMJ-ypa72aIo43x17k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46515@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

New review comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/46515#discussion_r1349672909

Comment:
This patch is not necessary. Flightgear doesn't use python (either version 2 or 3) and IIRC works fine even if python is not installed at all on the system.
The fgdata subpackage includes both files required at runtime and files needed during development (splitting them is not very straightforward). This file is part of the latter group.

  parent reply	other threads:[~2023-10-08 10:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-08  1:36 [PR PATCH] " classabbyamp
2023-10-08  1:58 ` [PR PATCH] [Updated] " classabbyamp
2023-10-08  6:03 ` classabbyamp
2023-10-08  6:04 ` classabbyamp
2023-10-08  6:43 ` classabbyamp
2023-10-08  7:37 ` classabbyamp
2023-10-08 10:28 ` r-ricci [this message]
2023-10-08 10:30 ` [PR REVIEW] " r-ricci
2023-10-08 14:30 ` classabbyamp
2023-10-08 19:56 ` [PR PATCH] [Updated] " classabbyamp
2023-10-09 23:36 ` classabbyamp
2023-10-10  1:39 ` classabbyamp
2023-10-10  1:41 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231008102826.RXEdVnp6LnkAqC-y4aHjY1SXwQMJ-ypa72aIo43x17k@z \
    --to=r-ricci@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).