* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
@ 2023-10-08 18:46 ` oreo639
2023-10-08 19:04 ` motorto
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2023-10-08 18:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752128113
Comment:
Lgtm, sorry for not looking into it sooner.
For reference:
https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/blob/main/src/power-profiles-daemon.c#L306
https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/blob/main/src/power-profiles-daemon.c#L270
And the daemon can only run as root.
Although I don't see any warnings in my syslog for some reason.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
2023-10-08 18:46 ` oreo639
@ 2023-10-08 19:04 ` motorto
2023-10-08 19:28 ` oreo639
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: motorto @ 2023-10-08 19:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752133488
Comment:
> Although I don't see any warnings in my syslog for some reason.
They should appear when changing the profile. (from balanced -> performance as an example)
> And the daemon can only run as root.
Yes I am running it at boot with runit
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
2023-10-08 18:46 ` oreo639
2023-10-08 19:04 ` motorto
@ 2023-10-08 19:28 ` oreo639
2023-10-08 19:31 ` oreo639
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2023-10-08 19:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752140643
Comment:
> Yes I am running it at boot with runit
Yeah, I'm just saying that `/var/lib/power-profiles-daemon 0600 root root` is correct.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (2 preceding siblings ...)
2023-10-08 19:28 ` oreo639
@ 2023-10-08 19:31 ` oreo639
2023-10-08 19:33 ` oreo639
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2023-10-08 19:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752140643
Comment:
> Yes I am running it at boot with runit
Yeah, I'm just saying that the `make_dirs` is correct.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (3 preceding siblings ...)
2023-10-08 19:31 ` oreo639
@ 2023-10-08 19:33 ` oreo639
2023-10-08 19:34 ` oreo639
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2023-10-08 19:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752140643
Comment:
> Yes I am running it at boot with runit
Yeah, I'm just saying that ownership of `make_dirs` is correct, although it probably can be made readable by everyone.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (4 preceding siblings ...)
2023-10-08 19:33 ` oreo639
@ 2023-10-08 19:34 ` oreo639
2023-10-08 21:01 ` motorto
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2023-10-08 19:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752140643
Comment:
> Yes I am running it at boot with runit
Yeah, I'm just saying that ownership of `make_dirs` is correct, although the permissions probably can be made readable by everyone.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (5 preceding siblings ...)
2023-10-08 19:34 ` oreo639
@ 2023-10-08 21:01 ` motorto
2023-10-08 21:23 ` oreo639
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: motorto @ 2023-10-08 21:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752160677
Comment:
> > Yes I am running it at boot with runit
>
> Yeah, I'm just saying that ownership of `make_dirs` is correct, although the permissions probably can be made readable by everyone.
644 then ?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (6 preceding siblings ...)
2023-10-08 21:01 ` motorto
@ 2023-10-08 21:23 ` oreo639
2023-10-08 21:24 ` oreo639
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2023-10-08 21:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752165561
Comment:
No, the folder would need to be `0755` for it to be readable.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (7 preceding siblings ...)
2023-10-08 21:23 ` oreo639
@ 2023-10-08 21:24 ` oreo639
2023-10-09 9:53 ` [PR PATCH] [Updated] " motorto
2023-10-10 8:34 ` [PR PATCH] [Merged]: " sgn
10 siblings, 0 replies; 12+ messages in thread
From: oreo639 @ 2023-10-08 21:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by oreo639 on void-packages repository
https://github.com/void-linux/void-packages/pull/46521#issuecomment-1752165561
Comment:
No, the folder would need to be `0755` for its contents to be readable.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Updated] power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (8 preceding siblings ...)
2023-10-08 21:24 ` oreo639
@ 2023-10-09 9:53 ` motorto
2023-10-10 8:34 ` [PR PATCH] [Merged]: " sgn
10 siblings, 0 replies; 12+ messages in thread
From: motorto @ 2023-10-09 9:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
There is an updated pull request by motorto against master on the void-packages repository
https://github.com/motorto/void-packages power-profiles-daemon-var-fix
https://github.com/void-linux/void-packages/pull/46521
power-profiles-daemon: create /var/lib/power-profiles-daemon
@oreo639
Fixes the following warning, that spams the log:
```
daemon.notice: Oct 8 17:58:12 power-profiles-daemon: ** (power-profiles-daemon:833): WARNING **: 17:58:12.124: Could not save configuration file '/var/lib/power-profiles-daemon/state.ini': Failed to create file ?/var/lib/power-profiles-daemon/state.ini.AKGIC2?: No such file or directory
```
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/46521.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-power-profiles-daemon-var-fix-46521.patch --]
[-- Type: text/x-diff, Size: 1697 bytes --]
From 29777938e35770047043dcbd7245ba5588c48388 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sun, 8 Oct 2023 17:58:57 +0100
Subject: [PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon
Fixes the following warning, that spams the log
```
daemon.notice: Oct 8 17:58:12 power-profiles-daemon: ** (power-profiles-daemon:833): WARNING **: 17:58:12.124: Could not save configuration file '/var/lib/power-profiles-daemon/state.ini': Failed to create file ?/var/lib/power-profiles-daemon/state.ini.AKGIC2?: No such file or directory
```
---
srcpkgs/power-profiles-daemon/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/power-profiles-daemon/template b/srcpkgs/power-profiles-daemon/template
index 0fdffbd409ab6..db8a48a219155 100644
--- a/srcpkgs/power-profiles-daemon/template
+++ b/srcpkgs/power-profiles-daemon/template
@@ -1,7 +1,7 @@
# Template file for 'power-profiles-daemon'
pkgname=power-profiles-daemon
version=0.13
-revision=2
+revision=3
build_style=meson
configure_args="-Dsystemdsystemunitdir=/usr/lib/systemd/system/"
hostmakedepends="pkg-config glib-devel"
@@ -15,6 +15,7 @@ homepage="https://gitlab.freedesktop.org/hadess/power-profiles-daemon"
changelog="https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/raw/main/NEWS"
distfiles="https://gitlab.freedesktop.org/hadess/power-profiles-daemon/-/archive/${version}/power-profiles-daemon-${version}.tar.gz"
checksum=74aac43eb43ebe5a3255a00eb48d781a5acfba32e96ab85737e22205e045e581
+make_dirs="/var/lib/power-profiles-daemon 0755 root root"
if [ "$XBPS_CHECK_PKGS" ]; then
configure_args+=" -Dtests=true"
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PR PATCH] [Merged]: power-profiles-daemon: create /var/lib/power-profiles-daemon
2023-10-08 17:00 [PR PATCH] power-profiles-daemon: create /var/lib/power-profiles-daemon motorto
` (9 preceding siblings ...)
2023-10-09 9:53 ` [PR PATCH] [Updated] " motorto
@ 2023-10-10 8:34 ` sgn
10 siblings, 0 replies; 12+ messages in thread
From: sgn @ 2023-10-10 8:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
There's a merged pull request on the void-packages repository
power-profiles-daemon: create /var/lib/power-profiles-daemon
https://github.com/void-linux/void-packages/pull/46521
Description:
@oreo639
Fixes the following warning, that spams the log:
```
daemon.notice: Oct 8 17:58:12 power-profiles-daemon: ** (power-profiles-daemon:833): WARNING **: 17:58:12.124: Could not save configuration file '/var/lib/power-profiles-daemon/state.ini': Failed to create file ?/var/lib/power-profiles-daemon/state.ini.AKGIC2?: No such file or directory
```
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
^ permalink raw reply [flat|nested] 12+ messages in thread