Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] tuxpaint: remove python 2 scripts
Date: Tue, 10 Oct 2023 05:48:26 +0200	[thread overview]
Message-ID: <20231010034826.b7rn5U_C-QuliQ-F332wMQ0rl9QWeuFh3s6hcwBd-gU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46542@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages tuxpaint
https://github.com/void-linux/void-packages/pull/46542

tuxpaint: remove python 2 scripts
- `maketuxfont.py` is impossible to easily port to python 3 because there is no equivalent to `string.letters` (set of all letters, locale-dependent). It is also probably not very useful in the modern era; it was created in 2005 when a "more then 13 MB" font file was considered huge.
- `mkTuxpaintIM.py` seems to be just for updating documentation (so probably not useful for users ever)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

@Chocimier 


A patch file from https://github.com/void-linux/void-packages/pull/46542.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tuxpaint-46542.patch --]
[-- Type: text/x-diff, Size: 1708 bytes --]

From 8a233adc970a032f3dc45c3ba32371c6741d9de7 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Mon, 9 Oct 2023 23:34:55 -0400
Subject: [PATCH] tuxpaint: remove python 2 scripts

- `maketuxfont.py` is impossible to easily port to python 3 because there is
  no equivalent to `string.letters` (set of all letters, locale-dependent)
  It is also probably not very useful in the modern era; it was created in 2005
  when a "more then 13 MB" font file was considered huge.
- `mkTuxpaintIM.py` seems to be just for updating documentation (so
  probably not useful for users ever)
---
 srcpkgs/tuxpaint/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tuxpaint/template b/srcpkgs/tuxpaint/template
index bacbfa432cb66..1113f084e117c 100644
--- a/srcpkgs/tuxpaint/template
+++ b/srcpkgs/tuxpaint/template
@@ -1,7 +1,7 @@
 # Template file for 'tuxpaint'
 pkgname=tuxpaint
 version=0.9.31
-revision=1
+revision=2
 build_style=gnu-makefile
 conf_files="/etc/tuxpaint/tuxpaint.conf"
 hostmakedepends="gettext gperf pkg-config ImageMagick"
@@ -15,7 +15,6 @@ homepage="https://www.tuxpaint.org/"
 distfiles="${SOURCEFORGE_SITE}/tuxpaint/${version}/tuxpaint-${version}.tar.gz"
 checksum=1a85c04fa5c9ae6b3ffd2ca8fa86a84c0c8b462b5059fa1fc2c445b5cfa857ee
 replaces="tuxpaint-data>=0"
-python_version=2
 CFLAGS="-D_GNU_SOURCE -D_POSIX_PRIORITY_SCHEDULING"
 
 pre_build() {
@@ -24,4 +23,7 @@ pre_build() {
 
 post_install() {
 	vinstall src/tuxpaint.desktop 644 usr/share/applications
+	# python 2
+	rm "${DESTDIR}/usr/share/doc/tuxpaint-${version}/outdated/zh_tw/mkTuxpaintIM.py" \
+		"${DESTDIR}/usr/share/tuxpaint/fonts/locale/zh_tw_docs/maketuxfont.py"
 }

  reply	other threads:[~2023-10-10  3:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10  3:42 [PR PATCH] " classabbyamp
2023-10-10  3:48 ` classabbyamp [this message]
2023-10-11 18:56 ` Chocimier
2023-10-11 18:56 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231010034826.b7rn5U_C-QuliQ-F332wMQ0rl9QWeuFh3s6hcwBd-gU@z \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).