[PR PATCH] connman: build with iwd support

[PR PATCH] connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]

There is a new pull request by rookiejet against master on the void-packages repository

https://github.com/rookiejet/void-packages connman-iwd
https://github.com/void-linux/void-packages/pull/46608

connman: build with iwd support
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Allows using `iwd` instead of `wpa_supplicant` for wireless connections.


A patch file from https://github.com/void-linux/void-packages/pull/46608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-connman-iwd-46608.patch --]
[-- Type: text/x-diff, Size: 1057 bytes --]

From 634fd5196c565abf94a05d764f03f7ed60aa0f2f Mon Sep 17 00:00:00 2001
From: Mazin Fadl <mazen@illumed.net>
Date: Wed, 9 Aug 2023 09:37:50 -0400
Subject: [PATCH] connman: build with iwd support

---
 srcpkgs/connman/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/connman/template b/srcpkgs/connman/template
index 26d414f6f7646..7eae2dda9a469 100644
--- a/srcpkgs/connman/template
+++ b/srcpkgs/connman/template
@@ -6,7 +6,8 @@ build_style=gnu-configure
 configure_args="--enable-polkit --enable-client --enable-pie --enable-ethernet
  --enable-wifi --enable-bluetooth --enable-loopback --enable-nmcompat
  --enable-openvpn --with-openvpn=/usr/bin/openvpn --enable-openconnect
- --disable-tools --disable-wispr --with-openconnect=/usr/bin/openconnect"
+ --enable-iwd --disable-tools --disable-wispr
+ --with-openconnect=/usr/bin/openconnect"
 hostmakedepends="automake iptables libtool pkg-config wpa_supplicant"
 makedepends="gnutls-devel iptables-devel libglib-devel libmnl-devel
  openconnect-devel readline-devel"

Re: connman: build with iwd support

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1759549962

Comment:
Does this mean the explicit dependency on `wpa_supplicant` should be removed, and backends listed in a README.voidlinux file?

Re: connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by rookiejet on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1760039306

Comment:
Yes, `wpa_supplicant` is an optional dependency. Per the src readme it's not required during build time to enable support for it in connman, it's only a runtime dependency.

Re: connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

New comment by rookiejet on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1760039306

Comment:
Yes, `wpa_supplicant` is an optional dependency. Per the src readme it's not required during build time to enable support for it in connman, it's only a runtime dependency.

Edit: Should I amend this commit with those changes? (And does the following work for README.voidlinux)

```
For WiFi support, install either 'wpa_supplicant' or 'iwd' to use as backends.
ConnMan defaults to 'wpa_supplicant' when it is found, to use 'iwd' add
'--wifi=iwd_agent' to its arguments in '/etc/sv/connmand/conf'.
```

Re: [PR PATCH] [Updated] connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

There is an updated pull request by rookiejet against master on the void-packages repository

https://github.com/rookiejet/void-packages connman-iwd
https://github.com/void-linux/void-packages/pull/46608

connman: build with iwd support
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Allows using `iwd` instead of `wpa_supplicant` for wireless connections.


A patch file from https://github.com/void-linux/void-packages/pull/46608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-connman-iwd-46608.patch --]
[-- Type: text/x-diff, Size: 1920 bytes --]

From cb613cd9afcdb65458c024fc60c49425a356aaa6 Mon Sep 17 00:00:00 2001
From: Mazin Fadl <mazen@illumed.net>
Date: Wed, 9 Aug 2023 09:37:50 -0400
Subject: [PATCH] connman: build with iwd support

---
 srcpkgs/connman/files/README.voidlinux | 3 +++
 srcpkgs/connman/template               | 9 +++++----
 2 files changed, 8 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/connman/files/README.voidlinux

diff --git a/srcpkgs/connman/files/README.voidlinux b/srcpkgs/connman/files/README.voidlinux
new file mode 100644
index 0000000000000..b7aa15ed3eea6
--- /dev/null
+++ b/srcpkgs/connman/files/README.voidlinux
@@ -0,0 +1,3 @@
+For WiFi support install either of 'wpa_supplicant' or 'iwd' to use as
+backend.  ConnMan defaults to 'wpa_supplicant', to use 'iwd' add
+'--wifi=iwd_agent' to its arguments in '/etc/sv/connmand/conf'.
diff --git a/srcpkgs/connman/template b/srcpkgs/connman/template
index 26d414f6f7646..7d99300fe0bab 100644
--- a/srcpkgs/connman/template
+++ b/srcpkgs/connman/template
@@ -1,16 +1,17 @@
 # Template file for 'connman'
 pkgname=connman
 version=1.42
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-polkit --enable-client --enable-pie --enable-ethernet
  --enable-wifi --enable-bluetooth --enable-loopback --enable-nmcompat
  --enable-openvpn --with-openvpn=/usr/bin/openvpn --enable-openconnect
- --disable-tools --disable-wispr --with-openconnect=/usr/bin/openconnect"
-hostmakedepends="automake iptables libtool pkg-config wpa_supplicant"
+ --enable-iwd --disable-tools --disable-wispr
+ --with-openconnect=/usr/bin/openconnect"
+hostmakedepends="automake iptables libtool pkg-config"
 makedepends="gnutls-devel iptables-devel libglib-devel libmnl-devel
  openconnect-devel readline-devel"
-depends="dbus wpa_supplicant"
+depends="dbus"
 short_desc="Open Source CONNection MANager"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-only"

Re: connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by rookiejet on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1760039306

Comment:
Yes, `wpa_supplicant` is an optional dependency. Per the src readme it's not required during build time to enable support for it in connman, it's only a runtime dependency.

Edit: Amended

Re: connman: build with iwd support

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1763372408

Comment:
Removing `wpa_supplicant` may break some users' installations if they remove orphans. I think the dependency should be kept for now and an `INSTALL.msg` should be added for a couple of release cycles to note that the dependency will be removed in the future and that users relying on it should mark `wpa_supplicant` manually installed.

Re: connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by rookiejet on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1763397081

Comment:
That's reasonable. `wpa_supplicant` is actually a dependency of `base-system` as well, so it won't be orphaned and uninstalled if it is removed from here. Would that suffice for this merge?

Re: connman: build with iwd support

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1763518112

Comment:
Not everybody uses `base-system`, so relying on its dependencies to not break `connman` is insufficient.

Re: [PR PATCH] [Updated] connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

There is an updated pull request by rookiejet against master on the void-packages repository

https://github.com/rookiejet/void-packages connman-iwd
https://github.com/void-linux/void-packages/pull/46608

connman: build with iwd support
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Allows using `iwd` instead of `wpa_supplicant` for wireless connections.


A patch file from https://github.com/void-linux/void-packages/pull/46608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-connman-iwd-46608.patch --]
[-- Type: text/x-diff, Size: 1696 bytes --]

From 2b149bbf11a0ba0138fe5363f15aad6f273bb6ec Mon Sep 17 00:00:00 2001
From: Mazin Fadl <mazen@illumed.net>
Date: Wed, 9 Aug 2023 09:37:50 -0400
Subject: [PATCH] connman: build with iwd support

---
 srcpkgs/connman/INSTALL.msg | 3 +++
 srcpkgs/connman/template    | 7 ++++---
 2 files changed, 7 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/connman/INSTALL.msg

diff --git a/srcpkgs/connman/INSTALL.msg b/srcpkgs/connman/INSTALL.msg
new file mode 100644
index 0000000000000..eeb26169c7ae6
--- /dev/null
+++ b/srcpkgs/connman/INSTALL.msg
@@ -0,0 +1,3 @@
+ConnMan's dependency on 'wpa_supplicant' will be removed in a future
+version. If you would like to keep using 'wpa_supplicant' as a Wi-Fi
+backend, please manually install it.
diff --git a/srcpkgs/connman/template b/srcpkgs/connman/template
index 26d414f6f7646..e908284366c43 100644
--- a/srcpkgs/connman/template
+++ b/srcpkgs/connman/template
@@ -1,13 +1,14 @@
 # Template file for 'connman'
 pkgname=connman
 version=1.42
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-polkit --enable-client --enable-pie --enable-ethernet
  --enable-wifi --enable-bluetooth --enable-loopback --enable-nmcompat
  --enable-openvpn --with-openvpn=/usr/bin/openvpn --enable-openconnect
- --disable-tools --disable-wispr --with-openconnect=/usr/bin/openconnect"
-hostmakedepends="automake iptables libtool pkg-config wpa_supplicant"
+ --enable-iwd --disable-tools --disable-wispr
+ --with-openconnect=/usr/bin/openconnect"
+hostmakedepends="automake iptables libtool pkg-config"
 makedepends="gnutls-devel iptables-devel libglib-devel libmnl-devel
  openconnect-devel readline-devel"
 depends="dbus wpa_supplicant"

Re: connman: build with iwd support

[rookiejet]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by rookiejet on void-packages repository

https://github.com/void-linux/void-packages/pull/46608#issuecomment-1764755741

Comment:
I revised the commit with @ahesford's recommendation, and included an INSTALL.msg

Re: [PR PATCH] [Merged]: connman: build with iwd support

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

There's a merged pull request on the void-packages repository

connman: build with iwd support
https://github.com/void-linux/void-packages/pull/46608

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Allows using `iwd` instead of `wpa_supplicant` for wireless connections.