From: chrysos349 <chrysos349@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: jellyfin-media-player-1.9.1
Date: Sat, 14 Oct 2023 15:31:18 +0200 [thread overview]
Message-ID: <20231014133118.QfcBX_9-v92PH9ZriAu3WchId8CUF5L4rUIaUGQNF7E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45830@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2542 bytes --]
New comment by chrysos349 on void-packages repository
https://github.com/void-linux/void-packages/pull/45830#issuecomment-1762893316
Comment:
> Web interface now added.
you added the link, but didn't add it properly to the package. it's absent in the compiled package.
Other suggestions:
`-DQTROOT='${XBPS_CROSS_BASE}/usr'` - not needed
`qt5-devel` is not needed because it will be pulled by other qt5-* deps.
```
https://repo.jellyfin.org/releases/server/portable/stable/web/jellyfin-web_${_web_version}_portable.tar.gz
```
this is the dynamic link for the web interface. next time it updates. the file won't be found.
here is the proper link
```
https://repo.jellyfin.org/releases/server/portable/versions/stable/web/${_ver}/jellyfin-web_${_ver}_portable.tar.gz
```
Below is a refactored template and a patch, which disables update checking, because it doesn't make any sense for our use. It works, and crossbuilds.
TEMPLATE
```
# Template file for 'jellyfin-media-player'
pkgname=jellyfin-media-player
version=1.9.1
_ver=10.8.11
revision=1
build_style=cmake
configure_args="-DCMAKE_BUILD_TYPE=Release -DLINUX_X11POWER=ON
-DOpenGL_GL_PREFERENCE=GLVND"
hostmakedepends="pkg-config python3 qt5-host-tools qt5-qmake"
makedepends="SDL2-devel libcec-devel mpv-devel qt5-declarative-devel
qt5-location-devel qt5-webchannel-devel qt5-webengine-devel qt5-x11extras-devel
zlib-devel"
depends="qt5-quickcontrols"
short_desc="Desktop media client for Jellyfin"
maintainer="inalone <me@inal.one>"
license="GPL-2.0-only"
homepage="https://github.com/jellyfin/jellyfin-media-player"
distfiles="https://github.com/jellyfin/jellyfin-media-player/archive/v${version}.tar.gz
https://repo.jellyfin.org/releases/server/portable/versions/stable/web/${_ver}/jellyfin-web_${_ver}_portable.tar.gz"
checksum="8d119bb78e897ace3041cf332114a79c51be4d8e0cc8c68f5745fd588c2b9bde
e78dd5c14e7929193478a350a79d5e9d52a27b0405b6080a7e556f608b89d764"
post_extract() {
mv ${pkgname}-${version}/* .
mkdir -p build/dist
mv jellyfin-web_*/* build/dist
}
```
PATCH
```
diff --git a/resources/settings/settings_description.json b/resources/settings/settings_description.json
index 20fff81..9979de5 100644
--- a/resources/settings/settings_description.json
+++ b/resources/settings/settings_description.json
@@ -118,7 +118,7 @@
},
{
"value": "checkForUpdates",
- "default": true
+ "default": false
},
{
"value": "enableInputRepeat",
```
next prev parent reply other threads:[~2023-10-14 13:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 20:20 [PR PATCH] " inalone
2023-08-30 19:40 ` [PR PATCH] [Updated] " inalone
2023-08-30 20:20 ` inalone
2023-09-11 8:56 ` inalone
2023-09-11 9:08 ` inalone
2023-09-11 9:09 ` inalone
2023-10-12 10:23 ` chrysos349
2023-10-12 19:02 ` inalone
2023-10-12 19:02 ` inalone
2023-10-12 19:24 ` chrysos349
2023-10-14 10:16 ` inalone
2023-10-14 10:39 ` [PR PATCH] [Updated] " inalone
2023-10-14 10:40 ` inalone
2023-10-14 10:40 ` [PR PATCH] [Updated] " inalone
2023-10-14 13:23 ` chrysos349
2023-10-14 13:31 ` chrysos349 [this message]
2023-10-14 18:34 ` [PR PATCH] [Updated] " inalone
2023-10-14 18:34 ` inalone
2024-01-13 1:46 ` github-actions
2024-01-13 1:47 ` chrysos349
2024-04-04 22:36 ` [PR PATCH] [Closed]: " inalone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014133118.QfcBX_9-v92PH9ZriAu3WchId8CUF5L4rUIaUGQNF7E@z \
--to=chrysos349@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).