From: dataCobra <dataCobra@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] godot: add correct build name
Date: Mon, 16 Oct 2023 13:17:16 +0200 [thread overview]
Message-ID: <20231016111716.XPu2uMJZIHFFZmw38DUQq0j9CoxQAMbCVmZAcFSfxSc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46589@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
There is an updated pull request by dataCobra against master on the void-packages repository
https://github.com/dataCobra/void-packages godot
https://github.com/void-linux/void-packages/pull/46589
godot: add correct build name
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
It's a minor change that makes debugging and reporting issues for our package easier.
Instead of ".custom_build" the suffix is ".voidlinux".
A patch file from https://github.com/void-linux/void-packages/pull/46589.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-46589.patch --]
[-- Type: text/x-diff, Size: 1050 bytes --]
From 9869c4bdf54220f3ec9cab03307d7f90091e5ecf Mon Sep 17 00:00:00 2001
From: dataCobra <datacobra@thinkbot.de>
Date: Wed, 11 Oct 2023 12:20:39 +0200
Subject: [PATCH] godot: add correct build name
---
srcpkgs/godot/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index fdcebd1017566..9a7446b403835 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.2
-revision=1
+revision=2
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -30,6 +30,7 @@ nocross=https://build.voidlinux.org/builders/armv7l_builder/builds/6342/steps/sh
CFLAGS+=" -fPIE -fPIC"
LDFLAGS+=" -pie"
+
if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
makedepends+=" libexecinfo-devel"
depends+=" libexecinfo"
@@ -47,6 +48,7 @@ make_build_args+=" arch=$arch"
pre_build() {
export CXXFLAGS=" $CXXFLAGS "
+ export BUILD_NAME="voidlinux"
}
post_patch() {
next prev parent reply other threads:[~2023-10-16 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 9:49 [PR PATCH] " dataCobra
2023-10-11 10:20 ` [PR PATCH] [Updated] " dataCobra
2023-10-16 11:17 ` dataCobra [this message]
2023-10-16 12:46 ` dataCobra
2023-10-16 21:05 ` [PR PATCH] [Merged]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016111716.XPu2uMJZIHFFZmw38DUQq0j9CoxQAMbCVmZAcFSfxSc@z \
--to=datacobra@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).