From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Fix cross-build for cysignals, cypari2, fpylll, primecountpy, pplpy
Date: Wed, 18 Oct 2023 01:15:42 +0200 [thread overview]
Message-ID: <20231017231542.XWOPcyBqO-sDMrCkZHtGa1fevHjUMjdstKOZb_GWKp8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46738@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
New review comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/46738#discussion_r1362914837
Comment:
I put this in a block by itself since I hope it will be upstreamed soon and I'll just remove this, but using the other hostmakedepends is ok.
About where to run autoconf, I tend to think it belongs more to the patch step than to the configure step. I.e. I only need to run it once after patching so I consider it part of patch (e.g. upstream ships configure included in the tarball, so patch+autoconf is creating a source dir similar to what upstream ships).
No big deal either way.
next prev parent reply other threads:[~2023-10-17 23:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 22:39 [PR PATCH] " tornaria
2023-10-17 15:18 ` dkwo
2023-10-17 20:39 ` [PR PATCH] [Updated] " tornaria
2023-10-17 20:45 ` tornaria
2023-10-17 20:57 ` [PR REVIEW] " classabbyamp
2023-10-17 23:15 ` tornaria [this message]
2023-10-18 22:59 ` [PR PATCH] [Updated] " tornaria
2023-10-19 1:53 ` tornaria
2023-10-19 1:54 ` tornaria
2023-10-19 11:21 ` tornaria
2023-10-19 11:23 ` [PR PATCH] [Updated] " tornaria
2023-10-20 0:37 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017231542.XWOPcyBqO-sDMrCkZHtGa1fevHjUMjdstKOZb_GWKp8@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).