From: Piraty <Piraty@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] synapse: update to 1.94.0.
Date: Wed, 25 Oct 2023 13:31:58 +0200 [thread overview]
Message-ID: <20231025113158.Es_bwjCmuUuRRGxb1chqO1SBaP_nIxyKs838GVCiV10@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46648@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/46648#discussion_r1370983236
Comment:
did you check that all other packages using pydantic still work?
synapse should not require pydantic2 (see https://github.com/matrix-org/synapse/blob/79f48b2b4fd6a90d919dc64f5a8d393c50cd5652/pyproject.toml#L215)
bumping pydantic to 2 seems worth its own PR
next prev parent reply other threads:[~2023-10-25 11:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 23:18 [PR PATCH] " TinfoilSubmarine
2023-10-13 0:29 ` [PR PATCH] [Updated] " TinfoilSubmarine
2023-10-13 0:30 ` TinfoilSubmarine
2023-10-14 23:37 ` [PR REVIEW] " Piraty
2023-10-15 3:17 ` [PR PATCH] [Updated] " TinfoilSubmarine
2023-10-15 3:46 ` [PR REVIEW] " TinfoilSubmarine
2023-10-19 12:09 ` [PR PATCH] [Updated] " TinfoilSubmarine
2023-10-19 12:44 ` TinfoilSubmarine
2023-10-19 12:49 ` [PR REVIEW] " TinfoilSubmarine
2023-10-24 14:10 ` [PR PATCH] [Updated] " TinfoilSubmarine
2023-10-25 11:31 ` Piraty
2023-10-25 11:31 ` [PR REVIEW] " Piraty
2023-10-25 11:31 ` Piraty [this message]
2023-10-25 11:31 ` Piraty
2023-10-25 12:08 ` [PR PATCH] [Updated] " TinfoilSubmarine
2023-10-25 12:53 ` [PR PATCH] [Merged]: synapse: update to 1.95.0 Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025113158.Es_bwjCmuUuRRGxb1chqO1SBaP_nIxyKs838GVCiV10@z \
--to=piraty@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).