From: mhmdanas <mhmdanas@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] vlc: update to 3.0.19.
Date: Mon, 30 Oct 2023 22:37:48 +0100 [thread overview]
Message-ID: <20231030213748.6fHIy67tbQ-FMOpRqntM9wGh2IxwjdgNAxmgtJ50y1E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46831@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1996 bytes --]
New review comment by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/pull/46831#discussion_r1376829312
Comment:
Actually, never mind, this worked for me (also has some misc changes in there, don't mind me):
```diff
diff --git a/srcpkgs/vlc/template b/srcpkgs/vlc/template
index d24428db5b8..baa76782f8e 100644
--- a/srcpkgs/vlc/template
+++ b/srcpkgs/vlc/template
@@ -63,7 +63,7 @@ case "$XBPS_TARGET_MACHINE" in
configure_args+=" --disable-altivec"
build_options_default+=" opengl"
;;
- armv[67]*)
+ armv[67]*|aarch64*)
# XXX only for rpi
build_options_default+=" rpi"
;;
@@ -76,20 +76,12 @@ fi
if [ "$build_option_rpi" ]; then
configure_args+=" --enable-omxil --enable-omxil-vout --enable-rpi-omxil"
makedepends+=" rpi-userland-devel"
-
- CFLAGS+=" -I${XBPS_CROSS_BASE}/opt/vc/include"
- CFLAGS+=" -I${XBPS_CROSS_BASE}/opt/vc/include/interface/vcos"
- CFLAGS+=" -I${XBPS_CROSS_BASE}/opt/vc/include/interface/vmcs_host/linux"
- CFLAGS+=" -I${XBPS_CROSS_BASE}/opt/vc/include/interface/vcos/pthreads"
-
- LDFLAGS="-L${XBPS_CROSS_BASE}/opt/vc/lib -Wl,-rpath=/opt/vc/lib -lbcm_host -lvcos -lvchiq_arm"
fi
pre_configure() {
NOCONFIGURE=1 ./bootstrap
- sed -i -e 's;tar cvvzf;tar cvzf;' share/Makefile.am share/Makefile.in
- sed 's|pl_shader_alloc(tc->pl_ctx, NULL, 0, 0);|pl_shader_alloc(tc->pl_ctx, NULL, 0);|' -i modules/video_output/opengl/vout_helper.c
+ vsed -i -e 's;tar cvvzf;tar cvzf;' share/Makefile.am share/Makefile.in
}
@@ -98,7 +90,7 @@ pre_install() {
# install .lua files instead of precompiled .luac ones
# scripts precompiled with 64 bit host compiler won’t run on 32 bit target
# same with respect to endianess
- sed -i -e "s/\(@list='\$(nobase_vlclib_DATA\)/\1:.luac=.lua/" share/Makefile
+ vsed -i -e "s/\(@list='\$(nobase_vlclib_DATA\)/\1:.luac=.lua/" share/Makefile
fi
}
```
Apply and push this diff and remove the common/shlibs change.
next prev parent reply other threads:[~2023-10-30 21:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46831@inbox.vuxu.org>
2023-10-25 16:32 ` [PR PATCH] [Updated] " jadynbrammer
2023-10-25 16:34 ` jadynbrammer
2023-10-30 21:15 ` [PR REVIEW] " mhmdanas
2023-10-30 21:37 ` mhmdanas [this message]
2023-10-30 21:37 ` mhmdanas
2023-11-09 18:22 ` classabbyamp
2023-11-09 18:24 ` classabbyamp
2023-11-10 20:49 ` [PR PATCH] [Updated] " jadynbrammer
2023-11-10 20:54 ` jadynbrammer
2023-11-10 20:55 ` jadynbrammer
2023-11-10 20:56 ` jadynbrammer
2023-11-10 21:06 ` classabbyamp
2023-11-10 21:17 ` [PR PATCH] [Updated] " jadynbrammer
2023-11-10 21:35 ` jadynbrammer
2023-11-10 21:41 ` classabbyamp
2023-11-10 22:03 ` [PR PATCH] [Updated] " jadynbrammer
2023-11-11 20:11 ` jadynbrammer
2023-11-11 20:53 ` classabbyamp
2023-11-11 21:30 ` jadynbrammer
2023-11-15 17:22 ` [PR PATCH] [Merged]: " Hoshpak
2023-11-15 17:22 ` Hoshpak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030213748.6fHIy67tbQ-FMOpRqntM9wGh2IxwjdgNAxmgtJ50y1E@z \
--to=mhmdanas@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).