From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: lighttpd: update to 1.4.73
Date: Tue, 31 Oct 2023 07:47:13 +0100 [thread overview]
Message-ID: <20231031064713.McqbnYV3g0T0stiTBJFJTLo7edPeKoLjZiw0vr07wB4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46978@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
New comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/46978#issuecomment-1786546685
Comment:
Tested here and it works
> Sounds like you think it more important for joe-user to say "yep, lighttpd serves my static file index.html on void linux." than the more extensive lighttpd test suite, which performs both unit tests and integration tests (e.g. full web request to a fastcgi server, an scgi server, CGI scripts, and more).
It's && not ||; test failure is fatal in CI and will block merging of a PR until the cause can be found and fixed, unless the test is found to be broken in the first place or needing fixtures that can't run in CI.
Manual testing is still required because of the variety of ways different packages do tests, and the extra work that would be required to verify that each one of them has enough tests and the right kind of tests that would catch runtime problems.
It is also important to check that things like the services Void ships for packages do in fact continue to work as packaged after the update.
next prev parent reply other threads:[~2023-10-31 6:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 5:26 [PR PATCH] " gstrauss
2023-10-31 5:29 ` classabbyamp
2023-10-31 5:30 ` classabbyamp
2023-10-31 5:43 ` gstrauss
2023-10-31 5:44 ` gstrauss
2023-10-31 5:49 ` gstrauss
2023-10-31 5:49 ` gstrauss
2023-10-31 5:50 ` classabbyamp
2023-10-31 5:50 ` classabbyamp
2023-10-31 5:51 ` gstrauss
2023-10-31 5:53 ` classabbyamp
2023-10-31 5:55 ` classabbyamp
2023-10-31 6:22 ` gstrauss
2023-10-31 6:47 ` 0x5c [this message]
2023-10-31 7:17 ` [PR PATCH] [Merged]: " classabbyamp
2023-10-31 15:59 ` gstrauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031064713.McqbnYV3g0T0stiTBJFJTLo7edPeKoLjZiw0vr07wB4@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).