Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] gpgme: package python binding
Date: Sun, 05 Nov 2023 04:29:40 +0100	[thread overview]
Message-ID: <20231105032940.P9iIGBZLNpP4Y6Xrl1N1bgYHAiKRuKnYMC8dZwFKlj4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47057@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/47057#discussion_r1382499424

Comment:
This is wrong; not only is it more complicated than it needs to be, but it uses the wrong egg-info name. You should also declare the variables you create local. At a minimum, you can reduce this dance to somthing like:

```suggestion
		local _sitelib="${PKGDESTDIR}/${py3_sitelib}"
		vmove "${py3_sitelib}"
		mv "${_sitelib}"/gpg-*.egg/gpg "${_sitelib}"
		mv "${_sitelib}"/gpg-*.egg/EGG-INFO \
			"${_sitelib}/gpg-${version}-py${py3_ver}.egg-info"
```

However, it would be better still to figure out how to install the Python package the right way.

  parent reply	other threads:[~2023-11-05  3:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-04 10:08 [PR PATCH] " Luciogi
2023-11-04 10:25 ` [PR PATCH] [Updated] gpgme: package python binding [Help] Luciogi
2023-11-04 13:13 ` Luciogi
2023-11-04 13:29 ` Luciogi
2023-11-04 15:32 ` Luciogi
2023-11-04 15:37 ` Luciogi
2023-11-04 19:04 ` Luciogi
2023-11-04 19:16 ` [PR PATCH] [Updated] gpgme: package python binding Luciogi
2023-11-04 19:20 ` [PR REVIEW] " classabbyamp
2023-11-04 20:09 ` [PR PATCH] [Updated] " Luciogi
2023-11-04 20:12 ` Luciogi
2023-11-04 20:13 ` Luciogi
2023-11-04 20:14 ` [PR REVIEW] " Luciogi
2023-11-05  3:29 ` ahesford [this message]
2023-11-05  7:56 ` [PR PATCH] [Updated] " Luciogi
2023-11-05  8:33 ` [PR REVIEW] " Luciogi
2023-11-05 12:40 ` classabbyamp
2023-11-05 12:40 ` classabbyamp
2023-11-06  9:37 ` [PR PATCH] [Updated] " Luciogi
2024-02-05  1:45 ` github-actions
2024-02-06 19:01 ` [PR REVIEW] " classabbyamp
2024-02-07  7:55 ` [PR PATCH] [Updated] " Luciogi
2024-02-07  7:55 ` [PR REVIEW] " Luciogi
2024-02-10  8:18 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231105032940.P9iIGBZLNpP4Y6Xrl1N1bgYHAiKRuKnYMC8dZwFKlj4@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).