From: icp1994 <icp1994@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically
Date: Sun, 05 Nov 2023 06:31:28 +0100 [thread overview]
Message-ID: <20231105053128.Rv_okg2WvFlzmeh4K-Ua311lNpX5H4L4fkOE9XMJwVY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45462@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
There is an updated pull request by icp1994 against master on the void-packages repository
https://github.com/icp1994/void-packages build-style/cargo
https://github.com/void-linux/void-packages/pull/45462
common/build-helper/rust.sh: link to libgit2 and libsqlite3 dynamically
libgit2 upstream: https://github.com/rust-lang/git2-rs/commit/59a81cac9ada22b5ea6ca2841f5bd1229f1dd659
libsqlite3 upstream: https://github.com/rusqlite/rusqlite/commit/b4604f2421315040133717f48f616200e10507a8
#### Testing the changes
- I tested the changes in this PR: **NO**
#### Local build testing
- I built this PR locally for my native architecture: **x86_64**
Neither crates has a release since inclusion of these overrides so don't know what the testing strategy here. Probably one or two packages will have broken builds which needs the respective `-devel` packages in the `makedepends`.
A patch file from https://github.com/void-linux/void-packages/pull/45462.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-build-style/cargo-45462.patch --]
[-- Type: text/x-diff, Size: 904 bytes --]
From 03ad71a109e32abcfaeddef102f64a6e00223aad Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Mon, 7 Aug 2023 01:04:55 +0530
Subject: [PATCH] common/build-helper/rust.sh: link to libgit2 and libsqlite3
dynamically
libgit2 upstream: https://github.com/rust-lang/git2-rs/commit/59a81cac9ada22b5ea6ca2841f5bd1229f1dd659
libsqlite3 upstream: https://github.com/rusqlite/rusqlite/commit/b4604f2421315040133717f48f616200e10507a8
---
common/build-helper/rust.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/common/build-helper/rust.sh b/common/build-helper/rust.sh
index 96ec351d545d9..5f2489c93ea95 100644
--- a/common/build-helper/rust.sh
+++ b/common/build-helper/rust.sh
@@ -61,3 +61,9 @@ export ZSTD_SYS_USE_PKG_CONFIG=1
# onig-sys
export RUSTONIG_SYSTEM_LIBONIG=1
+
+# libsqlite3-sys
+export LIBSQLITE3_SYS_USE_PKG_CONFIG=1
+
+# libgit2-sys
+export LIBGIT2_NO_VENDOR=1
next prev parent reply other threads:[~2023-11-05 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 19:46 [PR PATCH] " icp1994
2023-11-05 1:46 ` github-actions
2023-11-05 5:31 ` icp1994 [this message]
2023-11-26 8:32 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231105053128.Rv_okg2WvFlzmeh4K-Ua311lNpX5H4L4fkOE9XMJwVY@z \
--to=icp1994@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).