From 21093ed8cfe623454630bf813e60f1f51eb2b607 Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Mon, 6 Nov 2023 15:27:37 +0100
Subject: [PATCH] proftpd: update to 1.3.8a.

---
 srcpkgs/proftpd/patches/test.patch | 12 ++++++++++++
 srcpkgs/proftpd/template           | 12 ++++++++++--
 2 files changed, 22 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/proftpd/patches/test.patch

diff --git a/srcpkgs/proftpd/patches/test.patch b/srcpkgs/proftpd/patches/test.patch
new file mode 100644
index 0000000000000..f79f5e9734cc3
--- /dev/null
+++ b/srcpkgs/proftpd/patches/test.patch
@@ -0,0 +1,12 @@
+Proftpd expects that /etc/shells is populated for these tests, which is not the case in masterdirs
+--------
+--- a/tests/api/auth.c	2023-11-06 17:04:38.205368713 +0100
++++ -	2023-11-06 17:05:20.578137395 +0100
+@@ -2224,7 +2224,6 @@
+   tcase_add_test(testcase, auth_get_anon_config_test);
+   tcase_add_test(testcase, auth_chroot_test);
+   tcase_add_test(testcase, auth_banned_by_ftpusers_test);
+-  tcase_add_test(testcase, auth_is_valid_shell_test);
+   tcase_add_test(testcase, auth_set_groups_test);
+   tcase_add_test(testcase, auth_get_home_test);
+   tcase_add_test(testcase, auth_set_max_password_len_test);
diff --git a/srcpkgs/proftpd/template b/srcpkgs/proftpd/template
index 8e9985cc0b127..fdf44f60105ec 100644
--- a/srcpkgs/proftpd/template
+++ b/srcpkgs/proftpd/template
@@ -1,18 +1,26 @@
 # Template file for 'proftpd'
 pkgname=proftpd
-version=1.3.7e
+version=1.3.8a
 revision=1
 build_style=gnu-configure
+make_check_target=check-api
 makedepends="libcap-devel"
+checkdepends="check-devel iana-etc"
+# Full test suite is quite long and depends on a few unpackages perl libs
+# perl-Test-Unit perl-HTTP-Message perl-LWP perl-Net-Address-IP-Local"
 short_desc="Highly configurable GPL-licensed FTP server software"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-3.0-or-later"
 homepage="http://www.proftpd.org/"
 changelog="https://github.com/proftpd/proftpd/blob/${version}/RELEASE_NOTES"
 distfiles="https://github.com/proftpd/proftpd/archive/v${version}.tar.gz"
-checksum=6e716a3b53ee069290399fce6dccf4c229fafe6ec2cb14db3778b7aa3f9a8c92
+checksum=56093b890a712220b09b98e29de2974a590e8fae6b36ed78c698a90945466aaf
 conf_files="/etc/proftpd.conf"
 
+if [ "$XBPS_CHECK_PKGS" ]; then
+	configure_args="--enable-tests"
+fi
+
 proftpd-devel_package() {
 	short_desc+=" - development files"
 	depends="proftpd>=${version}_${revision}"