Github messages for voidlinux
 help / color / mirror / Atom feed
From: oynqr <oynqr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] img2pdf: update to 0.5.0.
Date: Mon, 20 Nov 2023 11:21:04 +0100	[thread overview]
Message-ID: <20231120102104.6OEjAkggVWyzCy3WJoQR-PsNGbeeYo-VaN6Wesr0SIQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47296@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New review comment by oynqr on void-packages repository

https://github.com/void-linux/void-packages/pull/47296#discussion_r1398973156

Comment:
Not an expert on this, but it's probably how ImageMagick calculates bit depth and is intended. I'll open an issue with img2pdf about tests failing on i686 (and probably other 32-bit arches).

  parent reply	other threads:[~2023-11-20 10:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18  9:13 [PR PATCH] " oynqr
2023-11-18 10:24 ` [PR PATCH] [Updated] " oynqr
2023-11-20  5:41 ` [PR REVIEW] " classabbyamp
2023-11-20 10:21 ` oynqr [this message]
2023-12-01  6:53 ` [PR PATCH] [Updated] " oynqr
2024-03-01  1:46 ` img2pdf: update to 0.5.1 github-actions
2024-03-16  1:44 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231120102104.6OEjAkggVWyzCy3WJoQR-PsNGbeeYo-VaN6Wesr0SIQ@z \
    --to=oynqr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).