From: Vaelatern <Vaelatern@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: GNS3 and dynamips updates
Date: Fri, 24 Nov 2023 21:15:17 +0100 [thread overview]
Message-ID: <20231124201517._4WjdG86zuAyDVXdSUQAHmZ7Ww_YTgkISvJo51gbCn0@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-41472@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/41472#issuecomment-1826055781
Comment:
@tsndqst I've got a PR open: #47331
I'd rather merge your PR.
Please update to 2.2.44, drop the `.patch` file... I'm not sure `makedepends="${hostmakedepends}` is necessary, the `hostmakedepends` bit. Please either justify the extra python pkg or not.
Also please do not change PATH to prefix with the cross dir. GNS3's build has an environment variable, I believe `$BUSYBOX_PATH` or similar, which it checks before looking on `PATH` for a `busybox.static`. Set that instead.
`python3-platformdirs` is a `depends` not a `checkdepends`. See my PR #47331.
With these changes, I'll merge this PR.
I'm currently using GNS3 on my x86_64-musl machine.
next prev parent reply other threads:[~2023-11-24 20:15 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 16:04 [PR PATCH] " tsndqst
2023-01-05 17:01 ` [PR PATCH] [Updated] " tsndqst
2023-01-05 17:10 ` tsndqst
2023-01-05 17:16 ` tsndqst
2023-01-05 22:48 ` [PR REVIEW] " CameronNemo
2023-01-05 23:51 ` tsndqst
2023-01-06 17:47 ` [PR PATCH] [Updated] " tsndqst
2023-01-06 17:57 ` tsndqst
2023-01-06 18:00 ` CameronNemo
2023-01-07 2:56 ` tsndqst
2023-01-07 4:02 ` CameronNemo
2023-01-07 14:51 ` tsndqst
2023-01-07 15:37 ` tsndqst
2023-01-08 15:30 ` [PR PATCH] [Updated] " tsndqst
2023-01-08 15:37 ` tsndqst
2023-01-08 15:40 ` tsndqst
2023-01-08 15:48 ` tsndqst
2023-01-08 15:57 ` tsndqst
2023-01-08 16:10 ` tsndqst
2023-01-08 16:13 ` tsndqst
2023-01-08 16:33 ` leahneukirchen
2023-01-25 15:00 ` tsndqst
2023-01-25 15:14 ` tsndqst
2023-01-25 15:47 ` [PR REVIEW] " CameronNemo
2023-01-25 16:19 ` tsndqst
2023-01-25 18:00 ` CameronNemo
2023-01-25 18:02 ` tsndqst
2023-01-25 19:11 ` [PR PATCH] [Updated] " tsndqst
2023-03-03 14:34 ` tsndqst
2023-05-08 12:44 ` tsndqst
2023-05-08 12:44 ` tsndqst
2023-06-06 19:26 ` [PR PATCH] [Updated] " tsndqst
2023-06-06 19:26 ` tsndqst
2023-06-06 20:02 ` [PR PATCH] [Updated] " tsndqst
2023-06-10 19:24 ` tsndqst
2023-07-10 1:09 ` tsndqst
2023-08-09 20:56 ` tsndqst
2023-09-19 17:13 ` tsndqst
2023-10-14 0:45 ` tsndqst
2023-10-14 0:48 ` tsndqst
2023-10-23 23:31 ` tsndqst
2023-10-30 19:00 ` SpidFightFR
2023-10-30 19:01 ` SpidFightFR
2023-10-30 19:15 ` tsndqst
2023-11-24 20:15 ` Vaelatern [this message]
2023-11-25 3:21 ` [PR PATCH] [Updated] " tsndqst
2023-11-25 3:22 ` tsndqst
2023-11-27 5:50 ` Vaelatern
2023-11-27 5:51 ` [PR PATCH] [Merged]: " Vaelatern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124201517._4WjdG86zuAyDVXdSUQAHmZ7Ww_YTgkISvJo51gbCn0@z \
--to=vaelatern@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).