Re: [PR PATCH] [Updated] binutils: enable targets supported by Void

[Piraty <Piraty@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]

There is an updated pull request by Piraty against master on the void-packages repository

https://github.com/Piraty/void-packages binutils-more-targets
https://github.com/void-linux/void-packages/pull/47381

binutils: enable targets supported by Void
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

ping @sgn @oreo639 @leahneukirchen 
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47381.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-binutils-more-targets-47381.patch --]
[-- Type: text/x-diff, Size: 2129 bytes --]

From cbdaf942793600d89a2c173aadbc1b7c46176100 Mon Sep 17 00:00:00 2001
From: Piraty <mail@piraty.dev>
Date: Sat, 25 Nov 2023 03:40:59 +0100
Subject: [PATCH] binutils: enable targets supported by Void

---
 srcpkgs/binutils/template | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/binutils/template b/srcpkgs/binutils/template
index 441e435539044..8aa1facb1df15 100644
--- a/srcpkgs/binutils/template
+++ b/srcpkgs/binutils/template
@@ -1,7 +1,7 @@
 # Template file for 'binutils'
 pkgname=binutils
 version=2.39
-revision=2
+revision=3
 bootstrap=yes
 hostmakedepends="pkgconf"
 makedepends="zlib-devel"
@@ -12,7 +12,11 @@ homepage="http://www.gnu.org/software/binutils/"
 distfiles="${GNU_SITE}/binutils/binutils-${version}.tar.xz"
 checksum=645c25f563b8adc0a81dbd6a41cffbf4d37083a382e02d5d3df4f65c09516d00
 
+build_options="all_targets"
+desc_option_all_targets="Enable all supported targets"
+
 subpackages="binutils-doc"
+
 if [ "$CHROOT_READY" ]; then
 	hostmakedepends+=" flex perl texinfo"
 	makedepends+=" elfutils-devel"
@@ -47,22 +51,29 @@ do_configure() {
 
 	# gprofng currently only supports x86 and aarch64 glibc.
 	case "$XBPS_TARGET_MACHINE" in
-		x86_64|i386|aarch64) conf+=" --enable-gprofng" ;;
+		x86_64|i686|aarch64) conf+=" --enable-gprofng" ;;
 		*) conf+=" --disable-gprofng" ;;
 	esac
 
+	extra_targets=
 	case "$XBPS_TARGET_MACHINE" in
 		ppc*)
 			conf+=" --enable-secureplt"
 			;;
-		x86_64*)
-			conf+=" --enable-targets=x86_64-pep"
-			;;
-		i686*)
-			conf+=" --enable-targets=x86_64-linux-gnu,x86_64-pep"
+		x86_64*|i686*)
+			extra_targets=x86_64-pep
 			;;
 	esac
 
+	# target archs supported by Void
+	# borked: riscv64 (gold doesn't support it)
+	void_targets="aarch64 armv5tel armv6l armv7l i686 mips mipsel ppc ppcle ppc64 ppc64le x86_64"
+	conf+=" --enable-targets=$(echo "$void_targets $extra_targets" | sed -e 's/ /-linux-gnu,/g')"
+
+	if [ "$build_option_all_targets" ]; then
+		conf+=" --enable-targets=all"
+	fi
+
 	# enable multilib on x86_64 glibc
 	if [ "$XBPS_TARGET_MACHINE" = "x86_64" ]; then
 		conf+=" --enable-multilib"