From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: distrobox-1.6.0.1-1
Date: Tue, 28 Nov 2023 05:17:30 +0100 [thread overview]
Message-ID: <20231128041730.hHkpqLSM_Zq8-XM7oPXAXTjd7-khqNnVvBnhgu_Fo5Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47347@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
New review comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/47347#discussion_r1407056577
Comment:
The policy on void for things like that is to not have an INSTALL message nor a `README.voidlinux` file, and instead rely on upstream documentation.
The install message is only for breaking changes, and the readme is only for void-specific information.
Distrobox provides clear documentation that one of these container runtimes is needed (including on the homepage), and clear [error messages](https://github.com/89luca89/distrobox/blob/main/distrobox-create#L472-L480) when none is available.
next prev parent reply other threads:[~2023-11-28 4:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 3:46 [PR PATCH] " klardotsh
2023-11-22 3:47 ` [PR PATCH] [Updated] " klardotsh
2023-11-22 3:51 ` klardotsh
2023-11-28 4:17 ` [PR REVIEW] " 0x5c
2023-11-28 4:17 ` 0x5c [this message]
2024-03-02 1:43 ` github-actions
2024-03-16 1:44 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128041730.hHkpqLSM_Zq8-XM7oPXAXTjd7-khqNnVvBnhgu_Fo5Q@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).