From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: python3-prompt_toolkit: disable workaround for ipython 8.18
Date: Fri, 01 Dec 2023 16:33:25 +0100 [thread overview]
Message-ID: <20231201153325.aYVryJ4DKa3bRk0Q2vJDNOlc2vsdA6iWdMJbuRoKKxI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47516@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2489 bytes --]
There's a merged pull request on the void-packages repository
python3-prompt_toolkit: disable workaround for ipython 8.18
https://github.com/void-linux/void-packages/pull/47516
Description:
See:
https://github.com/prompt-toolkit/python-prompt-toolkit/pull/1811#issuecomment-1827043359 https://github.com/prompt-toolkit/python-prompt-toolkit/pull/1821
Since the update to `prompt_toolkit-3.0.41_1` we get:
```
$ sage
┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 10.1, Release Date: 2023-08-20 │
│ Using Python 3.12.0. Type "help()" for help. │
└────────────────────────────────────────────────────────────────────┘
/usr/lib/python3.12/site-packages/prompt_toolkit/application/application.py:988: DeprecationWarning: There is no current event loop
loop = asyncio.get_event_loop()
```
This is due to https://github.com/prompt-toolkit/python-prompt-toolkit/pull/1811, which works around an issue with ipython <= 8.17. Since we already ship ipython 8.18 we can safely remove the workaround.
Note that I proposed this upstream and I was asked to do a PR, the patch here is taken from https://github.com/prompt-toolkit/python-prompt-toolkit/pull/1821.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
Cc: @ahesford
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
next prev parent reply other threads:[~2023-12-01 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 11:13 [PR PATCH] " tornaria
2023-12-01 15:33 ` ahesford [this message]
2023-12-12 14:11 ` tornaria
2023-12-12 14:12 ` ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201153325.aYVryJ4DKa3bRk0Q2vJDNOlc2vsdA6iWdMJbuRoKKxI@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).