From: tmtrucco <tmtrucco@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: spectrwm: update to 3.5.1, orphan
Date: Thu, 07 Dec 2023 03:16:44 +0100 [thread overview]
Message-ID: <20231207021644.P-kX5IHFWdY7kMrx5KhivgMWXoVZ07duxwDzsXNmtVE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47629@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2081 bytes --]
New comment by tmtrucco on void-packages repository
https://github.com/void-linux/void-packages/pull/47629#issuecomment-1844090377
Comment:
Sorry for the PR spam! I made the first PR with just the web and couldn't
figure out how to ammend the commit. I started all over again from terminal
with git so I can finally push the ammend. It should be good to go now,
sorry for the inconveniences
On Wed, Dec 6, 2023, 10:47 PM Mohammed Anas ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
>
> Thanks for your PR! Please don't keep closing your PRs and opening new
> ones just to make changes to them; instead, amend your commits and
> force-push to the existing PR branch (see
> https://www.atlassian.com/git/tutorials/rewriting-history).
> ------------------------------
>
> In srcpkgs/spectrwm/template
> <https://github.com/void-linux/void-packages/pull/47629#discussion_r1418197319>
> :
>
> > @@ -1,7 +1,7 @@
> # Template file for 'spectrwm'
> pkgname=spectrwm
> -version=3.4.1
> -revision=3
> +version=3.5.1
> +revision=4
>
> revision should be reset to 1 on version bumps.
> ------------------------------
>
> In srcpkgs/spectrwm/template
> <https://github.com/void-linux/void-packages/pull/47629#discussion_r1418197372>
> :
>
> > @@ -10,11 +10,11 @@ hostmakedepends="pkg-config"
> makedepends="libXcursor-devel libXft-devel libXrandr-devel libXt-devel
> xcb-util-keysyms-devel xcb-util-wm-devel"
> short_desc="Small dynamic tiling window manager for X11"
> -maintainer="Jakub Skrzypnik ***@***.***>"
> +maintainer=" Orphaned ***@***.***>"
>
> Remove the extra space
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/void-linux/void-packages/pull/47629#pullrequestreview-1768953838>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BDOOIZH46AKCGLWTNVJSGTDYIEN3ZAVCNFSM6AAAAABAKFNONGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONRYHE2TGOBTHA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
next prev parent reply other threads:[~2023-12-07 2:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 23:33 [PR PATCH] " tmtrucco
2023-12-07 1:47 ` [PR REVIEW] " mhmdanas
2023-12-07 1:47 ` mhmdanas
2023-12-07 2:11 ` [PR PATCH] [Updated] " tmtrucco
2023-12-07 2:16 ` tmtrucco [this message]
2023-12-10 2:34 ` mhmdanas
2023-12-19 15:41 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207021644.P-kX5IHFWdY7kMrx5KhivgMWXoVZ07duxwDzsXNmtVE@z \
--to=tmtrucco@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).