From: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [ISSUE] [CLOSED] [RFC] enable `XBPS_STRICT` by default
Date: Fri, 08 Dec 2023 02:46:58 +0100 [thread overview]
Message-ID: <20231208014658.QZzVDKsjiWFV75PEBfNY9Uk-D0tqJrUb3Jl9yKe4ajs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45507@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
Closed issue by mhmdanas on void-packages repository
https://github.com/void-linux/void-packages/issues/45507
Description:
<!--
if you are creating a bug report or package request, please fill out one of the forms here:
https://github.com/void-linux/void-packages/issues/new/choose
Don't request an update of a package, We have a script for that:
https://repo-default.voidlinux.org/void-updates/void-updates.txt
However, a quality pull request may help.
-->
When a `vsed` doesn't apply, they currently print a warning by default, and the build goes on. This can hide potential issues. `xbps-src` does have an `-s` flag, which in that case causes the build to stop at the failing vsed. This flag _is_ passed in the CI, but large PRs skip CI and so authors of those PRs may never notice the now-outdated `vsed`s (see e.g. https://github.com/void-linux/void-packages/issues/42441). Therefore, I propose enabling the "strict" `vsed` behavior by default, and would even go so far as to suggest removing the non-strict behavior, because I honestly don't see its point.
prev parent reply other threads:[~2023-12-08 1:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 16:24 [ISSUE] " mhmdanas
2023-08-09 16:29 ` Chocimier
2023-08-09 16:33 ` mhmdanas
2023-08-10 1:28 ` sgn
2023-08-10 15:13 ` mhmdanas
2023-08-10 15:13 ` mhmdanas
2023-08-17 19:40 ` ahesford
2023-08-17 20:11 ` mhmdanas
2023-08-17 20:20 ` classabbyamp
2023-08-17 22:34 ` mhmdanas
2023-08-25 6:29 ` sgn
2023-11-24 1:45 ` github-actions
2023-12-08 1:46 ` github-actions [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208014658.QZzVDKsjiWFV75PEBfNY9Uk-D0tqJrUb3Jl9yKe4ajs@z \
--to=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).