From: zlice <zlice@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: freecad: update to 0.21.1.
Date: Sat, 09 Dec 2023 17:56:12 +0100 [thread overview]
Message-ID: <20231209165612.MnWir1oq0iG5tlnbbo68vzuJnMY7qMdxkDqpG0hsksA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46573@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
New comment by zlice on void-packages repository
https://github.com/void-linux/void-packages/pull/46573#issuecomment-1848577244
Comment:
Actually looking at it again, just fixing the Manipulator mod isn't enough.
I think the FreeCAD Draft/importSVG mod needs patched ~1705
```
--- ./src/Mod/Draft/importSVG.py 2023-08-30 22:32:05.000000000 -0400
+++ /lib/freecad/Mod/Draft/importSVG.py 2023-12-09 11:41:56.315252658 -0500
@@ -1702,7 +1702,10 @@
contents = filename
else:
# Use the native Python open which was saved as `pythonopen`
- f = pythonopen(filename)
+ if (sys.version_info < (3, 12)): #py3
+ f = pythonopen(filename)
+ else:
+ f = open(filename)
contents = f.read()
f.close()
```
\*sigh* looking at it again, there's tons of regex strings that 3.12 isn't happy about. So prolly fine to do changes in another PR
next prev parent reply other threads:[~2023-12-09 16:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 0:52 [PR PATCH] " cy1der
2023-10-14 16:49 ` [PR PATCH] [Updated] " cy1der
2023-10-15 16:00 ` ii8
2023-10-15 17:05 ` cy1der
2023-10-15 17:05 ` cy1der
2023-10-15 17:06 ` cy1der
2023-10-15 19:15 ` [PR PATCH] [Updated] " cy1der
2023-10-15 19:19 ` cy1der
2023-10-15 20:17 ` ii8
2023-10-15 21:00 ` [PR PATCH] [Updated] " cy1der
2023-11-01 15:56 ` robertek
2023-11-01 17:09 ` [PR PATCH] [Updated] " cy1der
2023-11-01 17:10 ` cy1der
2023-11-14 21:49 ` zlice
2023-11-14 22:45 ` cy1der
2023-11-16 13:46 ` [PR REVIEW] " ahesford
2023-11-16 14:17 ` [PR PATCH] [Updated] " cy1der
2023-12-08 16:53 ` zlice
2023-12-09 16:21 ` zlice
2023-12-09 16:37 ` cy1der
2023-12-09 16:53 ` zlice
2023-12-09 16:56 ` zlice [this message]
2023-12-09 17:33 ` zlice
2023-12-09 17:42 ` zlice
2024-03-09 1:43 ` github-actions
2024-03-23 1:44 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231209165612.MnWir1oq0iG5tlnbbo68vzuJnMY7qMdxkDqpG0hsksA@z \
--to=zlice@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).