From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] wlroots: update to 0.17, cagebreak: update to 2.2.3
Date: Mon, 11 Dec 2023 17:06:49 +0100 [thread overview]
Message-ID: <20231211160649.Iuji4KRB5_NoIgq8z6EN3ZEJeHPRuOeb2prUV-slVho@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47655@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/47655#discussion_r1422733887
Comment:
```suggestion
makedepends="wlroots0.17-devel cairo-devel pango-devel libevdev-devel"
```
Moving the `libdisplay-info-devel` into dependencies for `wlroots0.17-devel` takes care of the requirement here, and I think every compositor template should depend directly on the specific wlroots package that it requires rather than allowing future updates to the metapackage to break builds.
next prev parent reply other threads:[~2023-12-11 16:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 21:39 [PR PATCH] wlroots: update to 0.17 migue07juegos
2023-12-08 23:31 ` [PR PATCH] [Updated] " migue07juegos
2023-12-11 16:06 ` [PR REVIEW] wlroots: update to 0.17, cagebreak: update to 2.2.3 ahesford
2023-12-11 16:06 ` ahesford
2023-12-11 16:06 ` ahesford [this message]
2023-12-11 16:18 ` ahesford
2023-12-11 16:53 ` [PR PATCH] [Updated] " migue07juegos
2023-12-11 17:01 ` [PR REVIEW] " migue07juegos
2023-12-11 18:25 ` ahesford
2023-12-11 18:51 ` ifreund
2023-12-11 19:46 ` ahesford
2023-12-11 21:00 ` [PR PATCH] [Updated] " migue07juegos
2023-12-12 4:57 ` ahesford
2023-12-12 4:57 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211160649.Iuji4KRB5_NoIgq8z6EN3ZEJeHPRuOeb2prUV-slVho@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).