Github messages for voidlinux
 help / color / mirror / Atom feed
From: meator <meator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: GZDoom reports its version as "<unknown version>"
Date: Sat, 16 Dec 2023 19:24:18 +0100	[thread overview]
Message-ID: <20231216182418.s0uLx8-G6ZX1gpbUoE6fB80lFJ8JtAdo3Rlv_GBGabI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47787@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/issues/47787#issuecomment-1858899634

Comment:
I won't make an effort fixing this because this doesn't affect the functionality of GZDoom. This is only "cosmetic".

If anyone else wants to fix this:
The relevant file is [https://github.com/ZDoom/gzdoom/blob/master/tools/updaterevision/UpdateRevision.cmake](https://github.com/ZDoom/gzdoom/blob/master/tools/updaterevision/UpdateRevision.cmake) (and https://github.com/ZDoom/gzdoom/blob/master/tools/updaterevision/gitinfo.h.in). It uses git to determine the version, hash and timestamp. Git isn't installed on host and the source comes from a tarball and not from git so this mechanism fails and defaults to `<unknown version>`.

      parent reply	other threads:[~2023-12-16 18:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-16  4:28 [ISSUE] " Jjp137
2023-12-16 17:40 ` meator
2023-12-16 18:24 ` meator [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231216182418.s0uLx8-G6ZX1gpbUoE6fB80lFJ8JtAdo3Rlv_GBGabI@z \
    --to=meator@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).