Github messages for voidlinux
 help / color / mirror / Atom feed
From: atk <atk@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] vscode: update to 1.85.1
Date: Tue, 19 Dec 2023 21:12:59 +0100	[thread overview]
Message-ID: <20231219201259.hDMWr6e3HhTjmtGA6NjGNLKayJIeV2wAsCF_i3xMxTc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47828@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by atk against master on the void-packages repository

https://github.com/atk/void-packages vscode-1.85.1
https://github.com/void-linux/void-packages/pull/47828

vscode: update to 1.85.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/47828.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-1.85.1-47828.patch --]
[-- Type: text/x-diff, Size: 2196 bytes --]

From 09c5525ac766ee5c7cc4271b28c9b526e7f4e096 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Tue, 19 Dec 2023 21:12:45 +0100
Subject: [PATCH] vscode: update to 1.85.1

---
 srcpkgs/vscode/template | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index d588f6e4aee85..0b24f520ce704 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,6 +1,6 @@
 # Template file for 'vscode'
 pkgname=vscode
-version=1.85.0
+version=1.85.1
 revision=1
 _electronver=24.3.0
 _npmver=8.6.0
@@ -12,13 +12,9 @@ maintainer="shizonic <realtiaz@gmail.com>, Alex Lohr <alex.lohr@logmein.com>"
 license="MIT"
 homepage="https://code.visualstudio.com/"
 distfiles="https://github.com/microsoft/vscode/archive/refs/tags/${version}.tar.gz"
-checksum=b7fcf4fce5ce31669e93240783ff9ecfbe6d239bb2446c5eb3c11900d430a727
+checksum=b16d2058a8961bb2753f6ff0d697694a670ff6f926b4b6ac63106c6eab168eca
 nocross=yes # x64 build does not cut it, it contains native code
 
-# Build fails on `yarn run gulp vscode-linux-x64-min`
-# See, e.g., https://build.voidlinux.org/builders/x86_64-musl_builder/builds/50400/steps/shell_3/logs/stdio
-broken="EMFILE: too many open files"
-
 if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
 	broken="FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory"
 fi
@@ -61,6 +57,7 @@ do_build() {
 	_mem_limit="--max_old_space_size=4095"
 
 	export NODE_OPTIONS="${_mem_limit}"
+
 	/usr/lib/node_modules/npm/bin/node-gyp-bin/node-gyp install \
 	--target=$_electronver \
 	--tarball=/usr/include/electron${_electronver%%.*}/node_headers.tar.gz
@@ -71,6 +68,11 @@ do_build() {
 
 	yarn install --frozen-lockfile --arch=x64
 
+  # patch node fs with graceful-fs to avoid using too many file descriptors
+	yarn add --dev graceful-fs@4.2.11
+	echo "require('graceful-fs').gracefulify(require('fs'));" > ${wrksrc}/use-graceful-fs.js
+	export NODE_OPTIONS="${_mem_limit} --require ${wrksrc}/use-graceful-fs.js"
+
 	# do not checksum electron, since we're using our own build
 	vsed -e "s/validateChecksum: true/validateChecksum: false/g" -i build/lib/electron.*s
 

  reply	other threads:[~2023-12-19 20:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 12:48 [PR PATCH] " atk
2023-12-19 20:12 ` atk [this message]
2023-12-20 22:04 ` [PR PATCH] [Merged]: " Duncaen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231219201259.hDMWr6e3HhTjmtGA6NjGNLKayJIeV2wAsCF_i3xMxTc@z \
    --to=atk@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).