From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: fix sort-dependencies to use checkdepends
Date: Mon, 25 Dec 2023 15:41:08 +0100 [thread overview]
Message-ID: <20231225144108.iUUQ6OOe1AKHl7E_Bz1Uzeem-1aplmX_VZoKsRci14A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47888@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/47888#issuecomment-1869011818
Comment:
> We need to ignore `checkdepends` during non-testing-build
This only affects order, in the sense that `sort-dependencies` will not add anything, just sort.
For example:
```
$ ./xbps-src sort-dependencies python3-pytest-cov
python3-pytest-cov
```
even if `python3-pytest-cov` checkdepends on `python3-process-tests`.
OTOH,in
```
$ ./xbps-src sort-dependencies python3-process-tests python3-pytest-cov
python3-pytest-cov
python3-process-tests
```
it is irrelevant for non-testing-build in which order these two packages are built, so it should not be a problem.
The only case where this would make a difference is if there is a build-check cycle. Then this will print a warning, and IMO it should be considered a bug.
Example:
```
$ XBPS_CHECK_PKGS=full ./xbps-src sort-dependencies python3-jupyter_server python3-jupyter_server_terminals
tsort: /tmp/tmp.owWM5auH2j: input contains a loop:
tsort: python3-jupyter_server
tsort: python3-jupyter_server_terminals
python3-jupyter_server_terminals
python3-jupyter_server
```
Note this is only a cycle because of `XBPS_CHECK_PKGS=full` which is one way build-check cycles can be broken. Indeed:
```
$ XBPS_CHECK_PKGS=yes ./xbps-src sort-dependencies python3-jupyter_server python3-jupyter_server_terminals
python3-jupyter_server_terminals
python3-jupyter_server
```
next prev parent reply other threads:[~2023-12-25 14:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 22:56 [PR PATCH] " tornaria
2023-12-25 8:30 ` sgn
2023-12-25 14:41 ` tornaria [this message]
2023-12-25 14:52 ` tornaria
2023-12-25 15:18 ` [PR PATCH] [Updated] " tornaria
2023-12-25 15:34 ` tornaria
2023-12-26 3:19 ` [PR PATCH] [Updated] " tornaria
2023-12-26 3:37 ` tornaria
2023-12-26 15:48 ` [PR PATCH] [Updated] " tornaria
2023-12-26 16:10 ` Include checkdepends in show-build-deps / fix sort-dependencies for CI tornaria
2024-02-15 15:15 ` Accept -Q / -K in show-build-deps, sort-dependencies, xbps-cycles.py tornaria
2024-03-18 2:58 ` tornaria
2024-04-07 21:06 ` tornaria
2024-04-08 1:57 ` [PR PATCH] [Merged]: " sgn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231225144108.iUUQ6OOe1AKHl7E_Bz1Uzeem-1aplmX_VZoKsRci14A@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).