Github messages for voidlinux
 help / color / mirror / Atom feed
From: desertsagebrush <desertsagebrush@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] i3status-rust: update to 0.32.3
Date: Mon, 25 Dec 2023 23:09:37 +0100	[thread overview]
Message-ID: <20231225220937.5R5qbjPbiuablOg1cJDtdiKCjOIxG9-G4nXWYpyMssA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47870@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

New review comment by desertsagebrush on void-packages repository

https://github.com/void-linux/void-packages/pull/47870#discussion_r1436159058

Comment:
Specifically, I've updated it to have this for a post_build (with just this and the addition of the build-helper, it is now failing on all builds...hence why I'm not pushing it):
```
post_build() {
	cargo auditable build --release --package xtask
	vtargetrun  "CARGO_MANIFEST_DIR=./xtask target/x86_64-unknown-linux-gnu/release/xtask generate-manpage"
}
```

Right now the rust target triple for the host architecture is hard-coded, as there doesn't seem to be a generic `xbps-src` variable for that since `XBPS_RUST_TARGET` is for the target. Definitely not

  parent reply	other threads:[~2023-12-25 22:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22  6:03 [PR PATCH] " desertsagebrush
2023-12-22  6:11 ` [PR PATCH] [Updated] " desertsagebrush
2023-12-22 18:22 ` desertsagebrush
2023-12-23 13:33 ` [PR REVIEW] " classabbyamp
2023-12-23 20:49 ` desertsagebrush
2023-12-23 20:52 ` desertsagebrush
2023-12-23 20:54 ` desertsagebrush
2023-12-23 21:09 ` classabbyamp
2023-12-23 21:13 ` classabbyamp
2023-12-25 21:57 ` desertsagebrush
2023-12-25 22:03 ` desertsagebrush
2023-12-25 22:09 ` desertsagebrush [this message]
2023-12-25 22:10 ` desertsagebrush
2023-12-25 22:15 ` desertsagebrush
2023-12-25 22:30 ` desertsagebrush
2023-12-25 22:34 ` desertsagebrush
2023-12-25 22:46 ` [PR PATCH] [Updated] " desertsagebrush
2023-12-25 22:48 ` desertsagebrush
2023-12-25 22:49 ` [PR REVIEW] " desertsagebrush
2023-12-25 22:51 ` desertsagebrush
2023-12-31 19:37 ` desertsagebrush
2024-01-07  4:56 ` [PR PATCH] [Updated] " classabbyamp
2024-01-07  4:57 ` classabbyamp
2024-01-07  4:57 ` classabbyamp
2024-01-07  5:14 ` [PR PATCH] [Merged]: " classabbyamp
2024-01-13 19:07 ` desertsagebrush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231225220937.5R5qbjPbiuablOg1cJDtdiKCjOIxG9-G4nXWYpyMssA@z \
    --to=desertsagebrush@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).