From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: [ci skip] glibc: fix memalign performance regression
Date: Wed, 27 Dec 2023 09:04:08 +0100 [thread overview]
Message-ID: <20231227080408.H9-2Y-Ccy3Fw1v0tuAjYiSxymZXdSJLvj0aNJ2OEMs4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47914@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
There's a merged pull request on the void-packages repository
[ci skip] glibc: fix memalign performance regression
https://github.com/void-linux/void-packages/pull/47914
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
The upgrade to 2.38 brought a very sad performance regression in sagemath:
```
$ time python -c 'from sage.graphs.generators.distance_regular import DoubleGrassmannGraph; print(DoubleGrassmannGraph(2,2))'
<string>:1: UserWarning: Resolving lazy import GF during startup
<string>:1: UserWarning: Resolving lazy import VectorSpace during startup
Double Grassmann graph (5, 2, 2)
real 0m30.101s
user 0m29.959s
sys 0m0.060s
```
while the same thing in 2.36 (or after this PR) takes ~ 1-2 seconds.
Thanks to @oreo639 for figuring out it was https://sourceware.org/bugzilla/show_bug.cgi?id=30723
Indeed, all the performance regressions I was seeing are gone now.
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
prev parent reply other threads:[~2023-12-27 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 22:40 [PR PATCH] " tornaria
2023-12-26 22:52 ` [PR PATCH] [Updated] " tornaria
2023-12-26 23:23 ` [PR PATCH] [Updated] [ci skip] " tornaria
2023-12-27 0:17 ` oreo639
2023-12-27 1:58 ` [PR PATCH] [Updated] " sgn
2023-12-27 1:58 ` [PR PATCH] [Closed]: " sgn
2023-12-27 8:04 ` sgn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231227080408.H9-2Y-Ccy3Fw1v0tuAjYiSxymZXdSJLvj0aNJ2OEMs4@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).