* Re: [PR REVIEW] New package: supersonic-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
@ 2023-12-29 17:44 ` classabbyamp
2023-12-29 19:01 ` michalszmidt
` (19 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-12-29 17:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438352233
Comment:
this already exists [upstream](https://github.com/dweymouth/supersonic/blob/main/res/supersonic-desktop.desktop), why are you adding it here?
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
2023-12-29 17:44 ` [PR REVIEW] " classabbyamp
@ 2023-12-29 19:01 ` michalszmidt
2023-12-29 19:03 ` classabbyamp
` (18 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 19:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]
New review comment by michalszmidt on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438375460
Comment:
There's no clear statement about the proper package name
whether it is `supersonic` or `supersonic-desktop`.
Repo name is supersonic, our build system outputs `supersonic` executable, headbar title is Supersonic, flatpak manifest says `io.github.dweymouth.supersonic` so I decided to stick to it as pacakge name.
When it comes to other repos.
- AUR has both options, lol
- nixpgs prefers `supersonic`
- YACP prefers `supersonic`
Desktop file seems to be the only place where it's referred as `supersonic-desktop`
```diff
--- a 2023-12-29 19:42:39.628481930 +0100
+++ b 2023-12-29 19:42:46.588597726 +0100
@@ -4,7 +4,7 @@
Name=Supersonic
Comment=A lightweight cross-platform desktop client for Subsonic music servers
Path=/usr/bin
-Exec=supersonic-desktop
+Exec=supersonic
Terminal=false
-Icon=supersonic-desktop
+Icon=/usr/share/pixmaps/supersonic/appicon.png
Categories=Audio;AudioVideo
```
I suppose it could be tweaked to output `supersonic-desktop` but it'll complicate template file and it's easier to maintain desktop file that changes rarely rather than patch.
But you decide.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
2023-12-29 17:44 ` [PR REVIEW] " classabbyamp
2023-12-29 19:01 ` michalszmidt
@ 2023-12-29 19:03 ` classabbyamp
2023-12-29 19:04 ` classabbyamp
` (17 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-12-29 19:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438375998
Comment:
follow upstream, not other downstreams
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (2 preceding siblings ...)
2023-12-29 19:03 ` classabbyamp
@ 2023-12-29 19:04 ` classabbyamp
2023-12-29 19:43 ` [PR PATCH] [Updated] " michalszmidt
` (16 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-12-29 19:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438376233
Comment:
we should not be carrying files like desktop files in tree, it's just clutter
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] New package: supersonic-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (3 preceding siblings ...)
2023-12-29 19:04 ` classabbyamp
@ 2023-12-29 19:43 ` michalszmidt
2023-12-29 19:43 ` michalszmidt
` (15 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 19:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
There is an updated pull request by michalszmidt against master on the void-packages repository
https://github.com/michalszmidt/void-packages new_supersonic
https://github.com/void-linux/void-packages/pull/47986
New package: supersonic-0.8.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47986.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_supersonic-47986.patch --]
[-- Type: text/x-diff, Size: 2453 bytes --]
From 3c0c56bd2f0589d1e0a501d18f71891cf986927c Mon Sep 17 00:00:00 2001
From: michalszmidt <michal.sz@disroot.org>
Date: Fri, 29 Dec 2023 18:19:50 +0100
Subject: [PATCH] New package: supersonic-desktop-0.8.2
---
.../files/supersonic.desktop | 10 +++++++
srcpkgs/supersonic-desktop/template | 28 +++++++++++++++++++
2 files changed, 38 insertions(+)
create mode 100644 srcpkgs/supersonic-desktop/files/supersonic.desktop
create mode 100644 srcpkgs/supersonic-desktop/template
diff --git a/srcpkgs/supersonic-desktop/files/supersonic.desktop b/srcpkgs/supersonic-desktop/files/supersonic.desktop
new file mode 100644
index 0000000000000..932a02f899d2f
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/files/supersonic.desktop
@@ -0,0 +1,10 @@
+[Desktop Entry]
+Type=Application
+Version=1.0
+Name=Supersonic
+Comment=A lightweight cross-platform desktop client for Subsonic music servers
+Path=/usr/bin
+Exec=supersonic
+Terminal=false
+Icon=/usr/share/pixmaps/supersonic/appicon.png
+Categories=Audio;AudioVideo
diff --git a/srcpkgs/supersonic-desktop/template b/srcpkgs/supersonic-desktop/template
new file mode 100644
index 0000000000000..8a0bc3e2dbca0
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/template
@@ -0,0 +1,28 @@
+# Template file for 'supersonic-desktop'
+pkgname=supersonic-desktop
+version=0.8.2
+revision=1
+build_style=go
+go_import_path="github.com/dweymouth/supersonic"
+hostmakedepends="pkg-config gcc"
+makedepends="libglvnd-devel mpv-devel libX11-devel libappindicator-devel libsecret-devel libXxf86vm-devel"
+depends="libsecret libappindicator"
+short_desc="Full-featured, mpv-based desktop client written in go for Subsonic and Jellyfin servers"
+maintainer="ITmodulo <itmodulo@disroot.org>"
+license="GPL-3.0"
+homepage="https://github.com/dweymouth/supersonic"
+distfiles="https://github.com/dweymouth/supersonic/archive/refs/tags/v${version}.tar.gz"
+checksum=55ce49566d3350fe789934310509763dc2646ea09cc5c8d364daca49d692b185
+
+post_build() {
+ # go install command has no possibility to change output file name
+ # https://github.com/golang/go/issues/47176
+ # There is confilicting supersonic package on GitHub, see repology
+ mv ${GOPATH}/bin/supersonic ${GOPATH}/bin/supersonic-desktop
+}
+
+post_install() {
+ mv res/appicon.png res/supersonic-desktop.png
+ vinstall res/supersonic-desktop.png 644 usr/share/pixmaps
+ vinstall res/supersonic-desktop.desktop 644 usr/share/applications
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] New package: supersonic-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (4 preceding siblings ...)
2023-12-29 19:43 ` [PR PATCH] [Updated] " michalszmidt
@ 2023-12-29 19:43 ` michalszmidt
2023-12-29 19:47 ` [PR REVIEW] New package: supersonic-desktop-0.8.2 michalszmidt
` (14 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 19:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
There is an updated pull request by michalszmidt against master on the void-packages repository
https://github.com/michalszmidt/void-packages new_supersonic
https://github.com/void-linux/void-packages/pull/47986
New package: supersonic-0.8.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47986.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_supersonic-47986.patch --]
[-- Type: text/x-diff, Size: 1785 bytes --]
From e5e38b4c87efc308acd61a48657f18dce99cca09 Mon Sep 17 00:00:00 2001
From: michalszmidt <michal.sz@disroot.org>
Date: Fri, 29 Dec 2023 18:19:50 +0100
Subject: [PATCH] New package: supersonic-desktop-0.8.2
---
srcpkgs/supersonic-desktop/template | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 srcpkgs/supersonic-desktop/template
diff --git a/srcpkgs/supersonic-desktop/template b/srcpkgs/supersonic-desktop/template
new file mode 100644
index 0000000000000..8a0bc3e2dbca0
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/template
@@ -0,0 +1,28 @@
+# Template file for 'supersonic-desktop'
+pkgname=supersonic-desktop
+version=0.8.2
+revision=1
+build_style=go
+go_import_path="github.com/dweymouth/supersonic"
+hostmakedepends="pkg-config gcc"
+makedepends="libglvnd-devel mpv-devel libX11-devel libappindicator-devel libsecret-devel libXxf86vm-devel"
+depends="libsecret libappindicator"
+short_desc="Full-featured, mpv-based desktop client written in go for Subsonic and Jellyfin servers"
+maintainer="ITmodulo <itmodulo@disroot.org>"
+license="GPL-3.0"
+homepage="https://github.com/dweymouth/supersonic"
+distfiles="https://github.com/dweymouth/supersonic/archive/refs/tags/v${version}.tar.gz"
+checksum=55ce49566d3350fe789934310509763dc2646ea09cc5c8d364daca49d692b185
+
+post_build() {
+ # go install command has no possibility to change output file name
+ # https://github.com/golang/go/issues/47176
+ # There is confilicting supersonic package on GitHub, see repology
+ mv ${GOPATH}/bin/supersonic ${GOPATH}/bin/supersonic-desktop
+}
+
+post_install() {
+ mv res/appicon.png res/supersonic-desktop.png
+ vinstall res/supersonic-desktop.png 644 usr/share/pixmaps
+ vinstall res/supersonic-desktop.desktop 644 usr/share/applications
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (5 preceding siblings ...)
2023-12-29 19:43 ` michalszmidt
@ 2023-12-29 19:47 ` michalszmidt
2023-12-29 19:48 ` [PR PATCH] [Updated] " michalszmidt
` (13 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 19:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
New review comment by michalszmidt on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438392048
Comment:
Fixed.
Renamed to `supersonic-desktop`
Actually there is at least one more `supersonic` project on gh.
- https://github.com/davidgfnet/supersonic-cpp
This is probably why it is now reffered as supersonic-desktop
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (6 preceding siblings ...)
2023-12-29 19:47 ` [PR REVIEW] New package: supersonic-desktop-0.8.2 michalszmidt
@ 2023-12-29 19:48 ` michalszmidt
2023-12-29 20:04 ` [PR REVIEW] " classabbyamp
` (12 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 19:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
There is an updated pull request by michalszmidt against master on the void-packages repository
https://github.com/michalszmidt/void-packages new_supersonic
https://github.com/void-linux/void-packages/pull/47986
New package: supersonic-desktop-0.8.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47986.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_supersonic-47986.patch --]
[-- Type: text/x-diff, Size: 1792 bytes --]
From b0eb4a12fb7d1dcf13607a46de640b6a8da79b40 Mon Sep 17 00:00:00 2001
From: michalszmidt <michal.sz@disroot.org>
Date: Fri, 29 Dec 2023 18:19:50 +0100
Subject: [PATCH] New package: supersonic-desktop-0.8.2
---
srcpkgs/supersonic-desktop/template | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 srcpkgs/supersonic-desktop/template
diff --git a/srcpkgs/supersonic-desktop/template b/srcpkgs/supersonic-desktop/template
new file mode 100644
index 0000000000000..aaa07334dfe8a
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/template
@@ -0,0 +1,28 @@
+# Template file for 'supersonic-desktop'
+pkgname=supersonic-desktop
+version=0.8.2
+revision=1
+build_style=go
+go_import_path="github.com/dweymouth/supersonic"
+hostmakedepends="pkg-config gcc"
+makedepends="libglvnd-devel mpv-devel libX11-devel libappindicator-devel libsecret-devel libXxf86vm-devel"
+depends="libsecret libappindicator"
+short_desc="Full-featured, mpv-based desktop client written in go for Subsonic and Jellyfin servers"
+maintainer="Michał Szmidt <michal.sz@disroot.org>"
+license="GPL-3.0"
+homepage="https://github.com/dweymouth/supersonic"
+distfiles="https://github.com/dweymouth/supersonic/archive/refs/tags/v${version}.tar.gz"
+checksum=55ce49566d3350fe789934310509763dc2646ea09cc5c8d364daca49d692b185
+
+post_build() {
+ # go install command has no possibility to change output file name
+ # https://github.com/golang/go/issues/47176
+ # There is confilicting supersonic package on GitHub, see repology
+ mv ${GOPATH}/bin/supersonic ${GOPATH}/bin/supersonic-desktop
+}
+
+post_install() {
+ mv res/appicon.png res/supersonic-desktop.png
+ vinstall res/supersonic-desktop.png 644 usr/share/pixmaps
+ vinstall res/supersonic-desktop.desktop 644 usr/share/applications
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (7 preceding siblings ...)
2023-12-29 19:48 ` [PR PATCH] [Updated] " michalszmidt
@ 2023-12-29 20:04 ` classabbyamp
2023-12-29 20:04 ` classabbyamp
` (11 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-12-29 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 218 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438396153
Comment:
move it in post_install after it's already in the destdir usr/bin
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (8 preceding siblings ...)
2023-12-29 20:04 ` [PR REVIEW] " classabbyamp
@ 2023-12-29 20:04 ` classabbyamp
2023-12-29 22:06 ` [PR PATCH] [Updated] " michalszmidt
` (10 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: classabbyamp @ 2023-12-29 20:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438396254
Comment:
use the vinstall rename argument (see manual.md)
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (9 preceding siblings ...)
2023-12-29 20:04 ` classabbyamp
@ 2023-12-29 22:06 ` michalszmidt
2023-12-29 22:07 ` [PR REVIEW] " michalszmidt
` (9 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 22:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
There is an updated pull request by michalszmidt against master on the void-packages repository
https://github.com/michalszmidt/void-packages new_supersonic
https://github.com/void-linux/void-packages/pull/47986
New package: supersonic-desktop-0.8.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47986.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_supersonic-47986.patch --]
[-- Type: text/x-diff, Size: 1788 bytes --]
From 59717e643525e9f5103cf5a7285d370441700f25 Mon Sep 17 00:00:00 2001
From: michalszmidt <michal.sz@disroot.org>
Date: Fri, 29 Dec 2023 18:19:50 +0100
Subject: [PATCH] New package: supersonic-desktop-0.8.2
---
srcpkgs/supersonic-desktop/template | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 srcpkgs/supersonic-desktop/template
diff --git a/srcpkgs/supersonic-desktop/template b/srcpkgs/supersonic-desktop/template
new file mode 100644
index 0000000000000..1aecd08637d65
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/template
@@ -0,0 +1,26 @@
+# Template file for 'supersonic-desktop'
+pkgname=supersonic-desktop
+version=0.8.2
+revision=1
+build_style=go
+go_import_path="github.com/dweymouth/supersonic"
+hostmakedepends="pkg-config gcc"
+makedepends="libglvnd-devel mpv-devel libX11-devel libappindicator-devel libsecret-devel libXxf86vm-devel"
+depends="libsecret libappindicator"
+short_desc="Full-featured, mpv-based desktop client written in go for Subsonic and Jellyfin servers"
+maintainer="Michał Szmidt <michal.sz@disroot.org>"
+license="GPL-3.0"
+homepage="https://github.com/dweymouth/supersonic"
+distfiles="https://github.com/dweymouth/supersonic/archive/refs/tags/v${version}.tar.gz"
+checksum=55ce49566d3350fe789934310509763dc2646ea09cc5c8d364daca49d692b185
+
+post_install() {
+ # go install command has no possibility to change name
+ # https://github.com/golang/go/issues/47176
+ # There is confilicting supersonic package on GitHub, see repology
+ # https://repology.org/projects/?search=supersonic
+ mv ${DESTDIR}/usr/bin/supersonic "${DESTDIR}/usr/bin/supersonic-desktop"
+
+ vinstall res/appicon.png 644 usr/share/pixmaps supersonic-desktop.png
+ vinstall res/supersonic-desktop.desktop 644 usr/share/applications
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (10 preceding siblings ...)
2023-12-29 22:06 ` [PR PATCH] [Updated] " michalszmidt
@ 2023-12-29 22:07 ` michalszmidt
2023-12-29 22:07 ` michalszmidt
` (8 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 22:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New review comment by michalszmidt on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438428288
Comment:
Done
`mv ${DESTDIR}/usr/bin/supersonic "${DESTDIR}/usr/bin/supersonic-desktop"`
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (11 preceding siblings ...)
2023-12-29 22:07 ` [PR REVIEW] " michalszmidt
@ 2023-12-29 22:07 ` michalszmidt
2024-01-01 23:50 ` Johnnynator
` (7 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2023-12-29 22:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New review comment by michalszmidt on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1438428358
Comment:
Done
`vinstall res/appicon.png 644 usr/share/pixmaps supersonic-desktop.png`
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (12 preceding siblings ...)
2023-12-29 22:07 ` michalszmidt
@ 2024-01-01 23:50 ` Johnnynator
2024-01-01 23:53 ` Johnnynator
` (6 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Johnnynator @ 2024-01-01 23:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1439101748
Comment:
```suggestion
short_desc="Full-featured, mpv-based music player written in go for Subsonic and Jellyfin servers"
```
I feel like mentioning `music` somewhere in the description is of value, since this is a music player after all
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (13 preceding siblings ...)
2024-01-01 23:50 ` Johnnynator
@ 2024-01-01 23:53 ` Johnnynator
2024-01-08 1:10 ` [PR PATCH] [Updated] " michalszmidt
` (5 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: Johnnynator @ 2024-01-01 23:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
New review comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1439101748
Comment:
```suggestion
short_desc="Full-featured, mpv-based music player for Subsonic and Jellyfin servers"
```
I feel like mentioning `music` somewhere in the description is of value, since this is a music player after all
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (14 preceding siblings ...)
2024-01-01 23:53 ` Johnnynator
@ 2024-01-08 1:10 ` michalszmidt
2024-01-08 1:15 ` [PR REVIEW] " michalszmidt
` (4 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2024-01-08 1:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
There is an updated pull request by michalszmidt against master on the void-packages repository
https://github.com/michalszmidt/void-packages new_supersonic
https://github.com/void-linux/void-packages/pull/47986
New package: supersonic-desktop-0.8.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47986.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_supersonic-47986.patch --]
[-- Type: text/x-diff, Size: 1821 bytes --]
From 3cf7755a66607b3383220a7e544579b15a351ef7 Mon Sep 17 00:00:00 2001
From: michalszmidt <michal.sz@disroot.org>
Date: Fri, 29 Dec 2023 18:19:50 +0100
Subject: [PATCH] New package: supersonic-desktop-0.8.2
---
srcpkgs/supersonic-desktop/template | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/supersonic-desktop/template
diff --git a/srcpkgs/supersonic-desktop/template b/srcpkgs/supersonic-desktop/template
new file mode 100644
index 0000000000000..5ab98b94f1de1
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/template
@@ -0,0 +1,25 @@
+# Template file for 'supersonic-desktop'
+pkgname=supersonic-desktop
+version=0.8.2
+revision=1
+build_style=go
+go_import_path="github.com/dweymouth/supersonic"
+hostmakedepends="pkg-config gcc"
+makedepends="libglvnd-devel mpv-devel libX11-devel libayatana-appindicator-devel libsecret-devel libXxf86vm-devel"
+depends="libsecret libayatana-appindicator"
+short_desc="Full-featured, mpv-based music player for Subsonic and Jellyfin servers"
+maintainer="Michał Szmidt <michal.sz@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dweymouth/supersonic"
+distfiles="https://github.com/dweymouth/supersonic/archive/refs/tags/v${version}.tar.gz"
+checksum=55ce49566d3350fe789934310509763dc2646ea09cc5c8d364daca49d692b185
+
+post_install() {
+ # go install command has no possibility to change name
+ # https://github.com/golang/go/issues/47176
+ # There is confilicting supersonic package on GitHub, see repology
+ # https://repology.org/projects/?search=supersonic
+ mv ${DESTDIR}/usr/bin/supersonic "${DESTDIR}/usr/bin/supersonic-desktop"
+ vinstall res/appicon.png 644 usr/share/pixmaps supersonic-desktop.png
+ vinstall res/supersonic-desktop.desktop 644 usr/share/applications
+}
\ No newline at end of file
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR REVIEW] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (15 preceding siblings ...)
2024-01-08 1:10 ` [PR PATCH] [Updated] " michalszmidt
@ 2024-01-08 1:15 ` michalszmidt
2024-01-08 17:26 ` [PR PATCH] [Updated] " michalszmidt
` (3 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2024-01-08 1:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 355 bytes --]
New review comment by michalszmidt on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#discussion_r1444111558
Comment:
Fixed:
- Changed desc to proposed by @Johnnynator
- replaced appindicator (just removed from repo) with libayatana-appindicator (works good, compiled tested)
- Replaced GPL-3.0 with GPL-3.0-or-later
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (16 preceding siblings ...)
2024-01-08 1:15 ` [PR REVIEW] " michalszmidt
@ 2024-01-08 17:26 ` michalszmidt
2024-01-09 2:20 ` michalszmidt
` (2 subsequent siblings)
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2024-01-08 17:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
There is an updated pull request by michalszmidt against master on the void-packages repository
https://github.com/michalszmidt/void-packages new_supersonic
https://github.com/void-linux/void-packages/pull/47986
New package: supersonic-desktop-0.8.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47986.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_supersonic-47986.patch --]
[-- Type: text/x-diff, Size: 1796 bytes --]
From 921609acb50921f2f6e377ec3881fe4573d48c93 Mon Sep 17 00:00:00 2001
From: michalszmidt <michal.sz@disroot.org>
Date: Fri, 29 Dec 2023 18:19:50 +0100
Subject: [PATCH] New package: supersonic-desktop-0.8.2
---
srcpkgs/supersonic-desktop/template | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 srcpkgs/supersonic-desktop/template
diff --git a/srcpkgs/supersonic-desktop/template b/srcpkgs/supersonic-desktop/template
new file mode 100644
index 0000000000000..2cbbcc026815e
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/template
@@ -0,0 +1,26 @@
+# Template file for 'supersonic-desktop'
+pkgname=supersonic-desktop
+version=0.8.2
+revision=1
+build_style=go
+go_import_path="github.com/dweymouth/supersonic"
+hostmakedepends="pkg-config gcc"
+makedepends="libglvnd-devel mpv-devel libX11-devel libayatana-appindicator-devel libsecret-devel libXxf86vm-devel"
+depends="libsecret libayatana-appindicator"
+short_desc="Full-featured, mpv-based music player for Subsonic and Jellyfin servers"
+maintainer="Michał Szmidt <michal.sz@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dweymouth/supersonic"
+distfiles="https://github.com/dweymouth/supersonic/archive/refs/tags/v${version}.tar.gz"
+checksum=55ce49566d3350fe789934310509763dc2646ea09cc5c8d364daca49d692b185
+
+post_install() {
+ # go install command has no possibility to change name
+ # https://github.com/golang/go/issues/47176
+ # There is confilicting supersonic package on GitHub, see repology
+ # https://repology.org/projects/?search=supersonic
+ mv ${DESTDIR}/usr/bin/supersonic "${DESTDIR}/usr/bin/supersonic-desktop"
+ vinstall res/appicon.png 644 usr/share/pixmaps supersonic-desktop.png
+ vinstall res/supersonic-desktop.desktop 644 usr/share/applications
+}
+
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Updated] New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (17 preceding siblings ...)
2024-01-08 17:26 ` [PR PATCH] [Updated] " michalszmidt
@ 2024-01-09 2:20 ` michalszmidt
2024-04-09 1:45 ` github-actions
2024-04-23 1:46 ` [PR PATCH] [Closed]: " github-actions
20 siblings, 0 replies; 22+ messages in thread
From: michalszmidt @ 2024-01-09 2:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
There is an updated pull request by michalszmidt against master on the void-packages repository
https://github.com/michalszmidt/void-packages new_supersonic
https://github.com/void-linux/void-packages/pull/47986
New package: supersonic-desktop-0.8.2
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/47986.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new_supersonic-47986.patch --]
[-- Type: text/x-diff, Size: 1793 bytes --]
From 94537ef1bdcf67ba3339d336a64335814c402114 Mon Sep 17 00:00:00 2001
From: michalszmidt <michal.sz@disroot.org>
Date: Fri, 29 Dec 2023 18:19:50 +0100
Subject: [PATCH] New package: supersonic-desktop-0.8.2
---
srcpkgs/supersonic-desktop/template | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
create mode 100644 srcpkgs/supersonic-desktop/template
diff --git a/srcpkgs/supersonic-desktop/template b/srcpkgs/supersonic-desktop/template
new file mode 100644
index 0000000000000..ca9cba3814760
--- /dev/null
+++ b/srcpkgs/supersonic-desktop/template
@@ -0,0 +1,25 @@
+# Template file for 'supersonic-desktop'
+pkgname=supersonic-desktop
+version=0.8.2
+revision=1
+build_style=go
+go_import_path="github.com/dweymouth/supersonic"
+hostmakedepends="pkg-config gcc"
+makedepends="libglvnd-devel mpv-devel libX11-devel libayatana-appindicator-devel libsecret-devel libXxf86vm-devel"
+depends="libsecret libayatana-appindicator"
+short_desc="Full-featured, mpv-based music player for Subsonic and Jellyfin servers"
+maintainer="Michał Szmidt <michal.sz@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/dweymouth/supersonic"
+distfiles="https://github.com/dweymouth/supersonic/archive/refs/tags/v${version}.tar.gz"
+checksum=55ce49566d3350fe789934310509763dc2646ea09cc5c8d364daca49d692b185
+
+post_install() {
+ # go install command has no possibility to change name
+ # https://github.com/golang/go/issues/47176
+ # There is confilicting supersonic package on GitHub, see repology
+ # https://repology.org/projects/?search=supersonic
+ mv ${DESTDIR}/usr/bin/supersonic "${DESTDIR}/usr/bin/supersonic-desktop"
+ vinstall res/appicon.png 644 usr/share/pixmaps supersonic-desktop.png
+ vinstall res/supersonic-desktop.desktop 644 usr/share/applications
+}
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (18 preceding siblings ...)
2024-01-09 2:20 ` michalszmidt
@ 2024-04-09 1:45 ` github-actions
2024-04-23 1:46 ` [PR PATCH] [Closed]: " github-actions
20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2024-04-09 1:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/47986#issuecomment-2043994799
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PR PATCH] [Closed]: New package: supersonic-desktop-0.8.2
2023-12-29 17:24 [PR PATCH] New package: supersonic-0.8.2 michalszmidt
` (19 preceding siblings ...)
2024-04-09 1:45 ` github-actions
@ 2024-04-23 1:46 ` github-actions
20 siblings, 0 replies; 22+ messages in thread
From: github-actions @ 2024-04-23 1:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
There's a closed pull request on the void-packages repository
New package: supersonic-desktop-0.8.2
https://github.com/void-linux/void-packages/pull/47986
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
- Works great with secret service and appindicator on KDE at least
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86-64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 22+ messages in thread