Re: [PR REVIEW] New package: supersonic-0.8.2

[michalszmidt <michalszmidt@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

New review comment by michalszmidt on void-packages repository

https://github.com/void-linux/void-packages/pull/47986#discussion_r1438375460

Comment:
There's no clear statement about the proper package name
whether it is `supersonic` or `supersonic-desktop`.

Repo name is supersonic, our build system outputs `supersonic` executable, headbar title is Supersonic, flatpak manifest says `io.github.dweymouth.supersonic` so I decided to stick to it as pacakge name.

When it comes to other repos.
- AUR has both options, lol
- nixpgs prefers `supersonic`
- YACP prefers `supersonic`

Desktop file seems to be the only place where it's referred as `supersonic-desktop`

```diff
--- a	2023-12-29 19:42:39.628481930 +0100
+++ b	2023-12-29 19:42:46.588597726 +0100
@@ -4,7 +4,7 @@
 Name=Supersonic
 Comment=A lightweight cross-platform desktop client for Subsonic music servers
 Path=/usr/bin
-Exec=supersonic-desktop
+Exec=supersonic
 Terminal=false
-Icon=supersonic-desktop
+Icon=/usr/share/pixmaps/supersonic/appicon.png
 Categories=Audio;AudioVideo
```

I suppose it could be tweaked to output `supersonic-desktop` but it'll complicate template file and it's easier to maintain desktop file that changes rarely rather than patch.

But you decide.