Re: [PR PATCH] [Updated] [RFC] optionally set GOPROXY, GOSUMDB when building go packages

[hazen2215 <hazen2215@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

There is an updated pull request by hazen2215 against master on the void-packages repository

https://github.com/hazen2215/void-packages XBPS_GOPROXY
https://github.com/void-linux/void-packages/pull/43668

[RFC] optionally set GOPROXY, GOSUMDB when building go packages
<!-- Uncomment relevant sections and delete options which are not applicable -->

<!-- #### Testing the changes -->
- I tested the changes in this PR: **YES**

This will allow xbps-src to set environment variable `GOPROXY` and `GOSUMDB` when building go packages.
When `GOPROXY` is set to `direct`, it pulls modules from source repositories like github and `git` and `mercurial` needs to be in `hostmakedepends`.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43668.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-XBPS_GOPROXY-43668.patch --]
[-- Type: text/x-diff, Size: 2627 bytes --]

From cd225876d34f65bbd760fb8700903b5cd4e9a840 Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Sat, 29 Apr 2023 17:33:50 +0900
Subject: [PATCH] xbps-src: optionally set GOPROXY, GOSUMDB when building go
 packages.

---
 common/environment/build-style/go.sh |  8 ++++++--
 etc/defaults.conf                    | 11 +++++++++++
 xbps-src                             |  2 +-
 3 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/common/environment/build-style/go.sh b/common/environment/build-style/go.sh
index 223bba83ff11b..7efc396fff945 100644
--- a/common/environment/build-style/go.sh
+++ b/common/environment/build-style/go.sh
@@ -17,6 +17,10 @@ else
 	fi
 fi
 
+case "$XBPS_GOPROXY" in
+	*direct*) hostmakedepends+=" git mercurial" ;;
+esac
+
 case "$XBPS_TARGET_MACHINE" in
 	aarch64*) export GOARCH=arm64;;
 	armv5*) export GOARCH=arm; export GOARM=5;;
@@ -41,8 +45,8 @@ export CGO_LDFLAGS="$LDFLAGS"
 export CGO_ENABLED="${CGO_ENABLED:-1}"
 export GO111MODULE=auto
 export GOTOOLCHAIN="${GOTOOLCHAIN:-local}"
-export GOPROXY="https://proxy.golang.org,direct"
-export GOSUMDB="sum.golang.org"
+export GOPROXY="${XBPS_GOPROXY:-https://proxy.golang.org,direct}"
+export GOSUMDB="${XBPS_GOSUMDB:-sum.golang.org}"
 
 case "$XBPS_TARGET_MACHINE" in
 	*-musl) export GOCACHE="${XBPS_HOSTDIR}/gocache-muslc" ;;
diff --git a/etc/defaults.conf b/etc/defaults.conf
index f70e4ea3d0067..2a8cf14d6adac 100644
--- a/etc/defaults.conf
+++ b/etc/defaults.conf
@@ -165,3 +165,14 @@ XBPS_SUCMD="sudo /bin/sh -c"
 # This can also be set or exported as a regular environment variable.
 #
 #XBPS_UPDATE_CHECK_VERBOSE=yes
+
+# [OPTIONAL]
+# Set the environment variable 'GOPROXY' when building go packages.
+# When set to 'direct', will download modules directly from source repositories
+#XBPS_GOPROXY=direct
+
+# [OPTIONAL]
+# Set the environment variable 'GOSUMDB' when building go packages.
+# When set to 'off', will disable querying for module checksum which is
+# undefined in go.sum.
+#XBPS_GOSUMDB=off
diff --git a/xbps-src b/xbps-src
index cdb5f8c6d643e..96c7562a57987 100755
--- a/xbps-src
+++ b/xbps-src
@@ -665,7 +665,7 @@ export XBPS_SHUTILSDIR XBPS_CROSSPFDIR XBPS_TRIGGERSDIR \
     XBPS_LIBEXECDIR XBPS_DISTDIR XBPS_DISTFILES_MIRROR XBPS_ALLOW_RESTRICTED \
     XBPS_USE_GIT_COMMIT_DATE XBPS_PKG_COMPTYPE XBPS_REPO_COMPTYPE \
     XBPS_BUILDHELPERDIR XBPS_USE_BUILD_MTIME XBPS_BUILD_ENVIRONMENT \
-    XBPS_PRESERVE_PKGS XBPS_IGNORE_BROKENNESS
+    XBPS_PRESERVE_PKGS XBPS_IGNORE_BROKENNESS XBPS_GOPROXY XBPS_GOSUMDB
 
 for i in REPOSITORY DESTDIR BUILDDIR SRCDISTDIR; do
     eval val="\$XBPS_$i"