Github messages for voidlinux
 help / color / mirror / Atom feed
From: CameronNemo <CameronNemo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] new package: incus
Date: Fri, 12 Jan 2024 22:03:18 +0100	[thread overview]
Message-ID: <20240112210318.BO7_p7mfJk9Iebczyfm3B24xaN-Jklxf3xQ2cutZM94@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-47573@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/47573#discussion_r1450922295

Comment:
Remove the cgroup changes. The user can fix the cgroups if necessary, but usually they should be using unified (i.e. cgroup2 only), and this would just be wrong in that case.

  parent reply	other threads:[~2024-01-12 21:03 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 16:30 [PR PATCH] [wip] new package: incus (replaces lxd) dkwo
2023-12-04 16:43 ` [PR PATCH] [Updated] " dkwo
2023-12-04 18:09 ` dkwo
2023-12-04 21:52 ` dkwo
2023-12-04 22:16 ` dkwo
2023-12-04 23:02 ` dkwo
2023-12-04 23:31 ` dkwo
2023-12-05 19:30 ` dkwo
2023-12-05 22:18 ` dkwo
2023-12-06 15:26 ` dkwo
2023-12-24 18:29 ` ahesford
2023-12-26 18:05 ` dkwo
2023-12-26 20:19 ` sbromberger
2023-12-26 20:20 ` sbromberger
2023-12-27 18:32 ` [PR PATCH] [Updated] " dkwo
2023-12-27 18:40 ` dkwo
2023-12-28 16:46 ` sbromberger
2023-12-28 16:49 ` sbromberger
2023-12-28 17:29 ` ahesford
2023-12-29 22:10 ` [PR PATCH] [Updated] " dkwo
2023-12-29 22:14 ` dkwo
2023-12-31 15:46 ` dkwo
2023-12-31 15:48 ` [PR PATCH] [Updated] " dkwo
2023-12-31 15:53 ` ahesford
2023-12-31 16:03 ` [PR PATCH] [Updated] " dkwo
2023-12-31 16:11 ` dkwo
2023-12-31 16:12 ` dkwo
2024-01-03 11:40 ` [PR PATCH] [Updated] new package: incus dkwo
2024-01-03 11:41 ` dkwo
2024-01-03 11:43 ` dkwo
2024-01-03 11:43 ` dkwo
2024-01-03 11:47 ` dkwo
2024-01-06 13:00 ` [PR PATCH] [Updated] " dkwo
2024-01-06 16:24 ` dkwo
2024-01-06 16:27 ` dkwo
2024-01-06 16:28 ` dkwo
2024-01-06 16:28 ` dkwo
2024-01-06 16:28 ` dkwo
2024-01-06 16:30 ` dkwo
2024-01-06 18:20 ` dkwo
2024-01-06 18:47 ` dkwo
2024-01-06 18:52 ` dkwo
2024-01-06 18:52 ` dkwo
2024-01-06 18:52 ` [PR PATCH] [Updated] " dkwo
2024-01-06 21:16 ` dkwo
2024-01-07 13:56 ` dkwo
2024-01-07 13:57 ` dkwo
2024-01-07 16:27 ` dkwo
2024-01-12 20:40 ` [PR REVIEW] " classabbyamp
2024-01-12 20:40 ` leahneukirchen
2024-01-12 20:41 ` classabbyamp
2024-01-12 20:41 ` classabbyamp
2024-01-12 20:42 ` classabbyamp
2024-01-12 21:03 ` CameronNemo [this message]
2024-01-13 19:57 ` [PR PATCH] [Updated] " dkwo
2024-01-13 19:58 ` [PR REVIEW] " dkwo
2024-01-13 19:58 ` dkwo
2024-01-13 19:58 ` dkwo
2024-01-13 19:58 ` dkwo
2024-01-13 19:59 ` dkwo
2024-01-13 19:59 ` dkwo
2024-01-13 20:30 ` classabbyamp
2024-01-14 10:34 ` [PR PATCH] [Updated] " dkwo
2024-01-16 19:35 ` dkwo
2024-01-23 18:21 ` sbromberger
2024-01-23 18:56 ` [PR PATCH] [Merged]: " ahesford
2024-01-24  4:36 ` sbromberger
2024-01-24  4:37 ` sbromberger
2024-01-24 15:14 ` dkwo
2024-01-24 16:05 ` sbromberger
2024-01-24 16:16 ` sbromberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112210318.BO7_p7mfJk9Iebczyfm3B24xaN-Jklxf3xQ2cutZM94@z \
    --to=cameronnemo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).