Github messages for voidlinux
 help / color / mirror / Atom feed
From: meator <meator@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] virtualbox-ose: Include UnattendedTemplates
Date: Fri, 12 Jan 2024 22:59:54 +0100	[thread overview]
Message-ID: <20240112215954.TJUncUMlZc1Hql1XB-m_uBvtmOMlqmmnsAxNeaJMin8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-48188@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages virtualbox
https://github.com/void-linux/void-packages/pull/48188

virtualbox-ose: Include UnattendedTemplates
These templates enable VirtualBox to do unattended installs. It fails with an error message complaining about missing
`/usr/share/virtualbox/UnattendedTemplates` without it.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/48188.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-virtualbox-48188.patch --]
[-- Type: text/x-diff, Size: 1113 bytes --]

From 0dc7648dc765d29a3bb321c952cebbf226834836 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Fri, 12 Jan 2024 22:36:44 +0100
Subject: [PATCH] virtualbox-ose: Include UnattendedTemplates

These templates enable VirtualBox to do unattended installs. It fails
with an error message complaining about missing
/usr/share/virtualbox/UnattendedTemplates without it.
---
 srcpkgs/virtualbox-ose/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/virtualbox-ose/template b/srcpkgs/virtualbox-ose/template
index c0cf9f0136c2a..46c5e2f3d6b92 100644
--- a/srcpkgs/virtualbox-ose/template
+++ b/srcpkgs/virtualbox-ose/template
@@ -1,7 +1,7 @@
 # Template file for 'virtualbox-ose'
 pkgname=virtualbox-ose
 version=7.0.12a
-revision=1
+revision=2
 short_desc="General-purpose full virtualizer for x86 hardware"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-only, CDDL-1.0"
@@ -116,6 +116,8 @@ do_install() {
 	vsv vboxwebsrv
 
 	vdoc ${FILESDIR}/README.voidlinux
+
+	vcopy UnattendedTemplates usr/share/virtualbox
 }
 
 virtualbox-ose-dkms_package() {

  parent reply	other threads:[~2024-01-12 21:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 21:44 [PR PATCH] " meator
2024-01-12 21:46 ` [PR REVIEW] " classabbyamp
2024-01-12 21:59 ` meator [this message]
2024-01-12 22:00 ` [PR PATCH] [Updated] " meator
2024-01-12 22:37 ` meator
2024-01-14  6:46 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240112215954.TJUncUMlZc1Hql1XB-m_uBvtmOMlqmmnsAxNeaJMin8@z \
    --to=meator@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).