From: github-actions [bot] <"github-actions [bot]"@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Closed]: Emulation Station: update to 2.11.2
Date: Wed, 17 Jan 2024 02:47:06 +0100 [thread overview]
Message-ID: <20240117014706.4F9E922DDF@inbox.vuxu.org> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46412@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]
There's a closed pull request on the void-packages repository
Emulation Station: update to 2.11.2
https://github.com/void-linux/void-packages/pull/46412
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
Seems to compile on armv6l.
The changes were tested exclusively on x86_64-glibc.
This change MAY break for other libs/arch's as it removes the patch to include ctime since the upstream adds time.h, if that happens I'll restore the patch - it seemed to work fine as I was testing it without the patch.
I imported https://github.com/RetroPie/EmulationStation/pull/618 as was recommended by https://github.com/RetroPie/EmulationStation/issues/819 with the intention being able to find installed data-files outside of the user's home directory.
The other change I made was to add files from the installer that typically go to a user's $HOME into /usr/share/EmulationStation/ to work with the patch.
This is intended to address https://github.com/void-linux/void-packages/issues/44861 .
In working with the patch, I bumped the version which might not have been necessary. If that should make a separate PR in the future please let me know.
prev parent reply other threads:[~2024-01-17 1:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 18:31 [PR PATCH] find data files and " namgo
2023-10-03 18:39 ` [PR PATCH] [Updated] Emulation Station: " namgo
2023-10-03 20:33 ` namgo
2024-01-02 1:47 ` github-actions
2024-01-17 1:47 ` github-actions [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117014706.4F9E922DDF@inbox.vuxu.org \
--to=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).